Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Hero and two columns" pattern #21130

Merged
merged 12 commits into from
May 12, 2020
Merged

Add 'Hero and two columns" pattern #21130

merged 12 commits into from
May 12, 2020

Conversation

enriquesanchez
Copy link
Contributor

Adds a block pattern for #20345.

Screen Shot 2020-03-24 at 18 29 27

@enriquesanchez enriquesanchez added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Mar 25, 2020
@enriquesanchez enriquesanchez self-assigned this Mar 25, 2020
@github-actions
Copy link

github-actions bot commented Mar 25, 2020 •
edited
Loading

Size Change: +3.19 kB (0%)

Total Size: 827 kB

Filename Size Change
build/api-fetch/index.js 4.08 kB +1 B
build/block-directory/index.js 6.63 kB +20 B (0%)
build/block-directory/style-rtl.css 764 B +4 B (0%)
build/block-directory/style.css 764 B +3 B (0%)
build/block-editor/index.js 104 kB +1.98 kB (1%)
build/block-editor/style-rtl.css 10.6 kB +257 B (2%)
build/block-editor/style.css 10.6 kB +254 B (2%)
build/block-library/editor-rtl.css 7.12 kB +39 B (0%)
build/block-library/editor.css 7.12 kB +37 B (0%)
build/block-library/index.js 115 kB -101 B (0%)
build/block-library/style-rtl.css 7.38 kB +103 B (1%)
build/block-library/style.css 7.38 kB +99 B (1%)
build/blocks/index.js 48.1 kB +1 B
build/components/index.js 181 kB +688 B (0%)
build/compose/index.js 6.66 kB -3 B (0%)
build/data/index.js 8.43 kB -11 B (0%)
build/edit-navigation/index.js 4.42 kB +20 B (0%)
build/edit-post/index.js 28 kB -73 B (0%)
build/edit-site/index.js 12.1 kB -148 B (1%)
build/edit-site/style-rtl.css 5.22 kB +13 B (0%)
build/edit-site/style.css 5.22 kB +11 B (0%)
build/edit-widgets/index.js 8.37 kB -2 B (0%)
build/editor/index.js 44.3 kB +1 B
build/element/index.js 4.65 kB -3 B (0%)
build/keyboard-shortcuts/index.js 2.51 kB -1 B
build/keycodes/index.js 1.94 kB -1 B
build/list-reusable-blocks/index.js 3.12 kB -1 B
build/media-utils/index.js 5.29 kB +3 B (0%)
build/notices/index.js 1.79 kB -1 B
build/nux/index.js 3.4 kB +1 B
build/primitives/index.js 1.5 kB -2 B (0%)
build/redux-routine/index.js 2.85 kB +1 B
build/rich-text/index.js 14.8 kB -3 B (0%)
build/server-side-render/index.js 2.68 kB +2 B (0%)
build/token-list/index.js 1.28 kB -1 B
build/url/index.js 4.02 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 17 kB 0 B
build/components/style.css 16.9 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/style-rtl.css 618 B 0 B
build/edit-navigation/style.css 617 B 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-widgets/style-rtl.css 4.69 kB 0 B
build/edit-widgets/style.css 4.69 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/style-rtl.css 5.07 kB 0 B
build/editor/style.css 5.08 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.63 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.14 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/shortcode/index.js 1.7 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@mtias
Copy link
Member

mtias commented Mar 25, 2020

Can we use a different gradient to the ABC! one?

@enriquesanchez
Copy link
Contributor Author

@mtias changed to blush-light-purple:

Screen Shot 2020-03-30 at 16 25 23

@enriquesanchez
Copy link
Contributor Author

Made some updates:

Screen Shot 2020-04-08 at 15 46 50

@enriquesanchez
Copy link
Contributor Author

Hi @mtias 👋

Wondering if you have any comments about this pattern. Let me know if you think it can be improved or if we should close this PR instead.

@mapk
Copy link
Contributor

mapk commented Apr 10, 2020

The one without the tan background works better here.

What if you drop the entire left column so that you have the large Cover block on top and then one right column with text below it?

@enriquesanchez
Copy link
Contributor Author

The one without the tan background works better here.

@mapk Oh, right. I'm using Twenty Twenty and that's the default background color. I'll switch to the Starter theme for this one as well.

What if you drop the entire left column so that you have the large Cover block on top and then one right column with text below it?

Is this what you had in mind?

Screen Shot 2020-04-14 at 17 49 53

@mapk
Copy link
Contributor

mapk commented Apr 30, 2020

I'd add a bit more spacing between the button and paragraph above it. But afterwards, good to go.

@enriquesanchez enriquesanchez force-pushed the add/hero-and-two-columns-pattern branch from cd81a06 to 652de5c Compare May 4, 2020 22:07
mapk
mapk approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@enriquesanchez enriquesanchez merged commit c7d5844 into master May 12, 2020
@enriquesanchez enriquesanchez deleted the add/hero-and-two-columns-pattern branch May 12, 2020 23:59
@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 12, 2020
@carolinan
Copy link
Contributor

Is the large text a paragraph on purpose if so, why? I believe it needs to be a heading for the text content below it.

@enriquesanchez
Copy link
Contributor Author

You make a good point @carolinan. There are two reasons why I used a Paragraph block:

  1. Because the Cover block starts with a Paragraph block by default.
  2. Not knowing where and how this pattern will be placed in relation to other content, I wasn't sure if I should make assumptions about what heading level to use, for example.

What do you think?

@ellatrix ellatrix mentioned this pull request Jun 16, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapk mapk mapk approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@mtias mtias Awaiting requested review from mtias

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees

@enriquesanchez enriquesanchez

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced
Projects
None yet
Milestone
Gutenberg 8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@enriquesanchez @mtias @mapk @carolinan