Storybook: Add DateTimePicker #22024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekhrabe
added
[Package] Components
marekhrabe
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: +7.87 kB (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
marekhrabe
added
the
Good First Review
earnjam
reviewed
May 7, 2020
There was a problem hiding this comment.
There is overlap between this and #22043.
As part of fixing a bug, that one adds the DateTimePicker to the storybook. But it also adds TimePicker and DatePicker as separate isolated components. Difference in this one is the use of state. Perhaps we can combine the two?
brentswisher
requested changes
May 13, 2020
There was a problem hiding this comment.
This is looking great, thank you for your work! One very minor change, if you could move the const is12Hour to the _default() function, and then in DateTimePickerWithState accept and pass on props to <DateTimePicker>. (If that doesn't make sense take a look at the checkbox-control story for an example of what I mean.)
To be clear, this will function the same as your code. The only reason for the change is it makes it more clear to end-users in storybook what is happening when viewing the code in the docs panel. Otherwise, all they see is <DateTimePickerWithState />: 
8 tasks
|
@brentswisher this makes sense. after my update:
|
|
I have just discovered that the same story was added in another PR: gutenberg/packages/components/src/date-time/stories/index.js Lines 21 to 36 in 29bb0e6 Let's close this PR. @marekhrabe, it looks like you landed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a simple story for the
DateTimePicker.How has this been tested?
In the storybook,
npm run storybook:devScreenshots
Types of changes
New feature (non-breaking change which adds functionality)