Add storybook story for the FocusableIframe component #22324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentswisher
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
brentswisher
added
[Package] Components
8 tasks
|
Size Change: 0 B Total Size: 831 kB ℹ️ View Unchanged
|
ajitbohra
approved these changes
May 18, 2020
| }; | ||
|
|
||
| export const _default = () => { | ||
| const source = text( 'iFrame Source', './' ); |
There was a problem hiding this comment.
how about using something else for the source?
There was a problem hiding this comment.
Any suggestions? I tried wordpress.org but it didn't work, I assumed because of security settings
|
Merging this to avoid letting an approved PR stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a storybook story for the FocusableIframe component as part of #17973
The accessibility checks in storybook pointed out that this component should have a title, I will follow up with a separate issue to address that.
How has this been tested?
npm run storybook:devScreenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: