Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Merge similar translation strings in rss block #24159

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Jul 23, 2020

Description

Moved from Track https://core.trac.wordpress.org/ticket/50739

This PR merges two similar translation strings.

Basically replacing "by" with "by %s". This will remove "by" string from translate.wordpress.org .

Screenshots

50739

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@Soean Soean added Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement. labels Jul 23, 2020
@Soean Soean merged commit 80b1bb5 into WordPress:master Jul 23, 2020
@github-actions github-actions bot added this to the Gutenberg 8.7 milestone Jul 23, 2020
@ramiy ramiy deleted the patch-2 branch July 23, 2020 19:35
@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 27, 2020
youknowriad pushed a commit that referenced this pull request Jul 27, 2020
* i18n: Merge similar translation strings in rss block

Moved from https://core.trac.wordpress.org/ticket/50739

* Add translation comment
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants