-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link color style property name in global styles #24296
Conversation
Size Change: +24 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
'--wp--style--color--link' => array( '__experimentalColor', 'linkColor' ), | ||
'background-color' => array( '__experimentalColor' ), | ||
'background' => array( '__experimentalColor', 'gradients' ), | ||
'block-align' => array( 'align' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense for me, though it's not introduced in this particular PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed it as well, made a note to review later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya! Sorry, that was my doing... does block align not belong in this function in general?
Its being used for checking if a block as align hook support here:
Line 421 in 1087121
if ( in_array( 'block-align', $supports, true ) ) { |
but I can remove it from this function and just check if the block_type has the align flag there instead if that makes more sense? I currently have #24300 open in this area to add support for default values and can update this there if needed. (Also I wouldn't mind any input/review on that PR, I didn't realize we missed the case for default values when we originally added those functions in #23007.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Riad already proposed an alternative at #24351
Extracted from #24250
This fixes the name of the style property for link color + sorts them alphabetically.