-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more style properties in the global context #24298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
the
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
label
Jul 30, 2020
youknowriad
reviewed
Jul 30, 2020
Size Change: -63 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
oandregal
force-pushed
the
add/support-more-styles-in-global-context
branch
from
July 30, 2020 18:09
f58aca4
to
5126866
Compare
oandregal
force-pushed
the
add/support-more-styles-in-global-context
branch
from
August 2, 2020 19:08
5126866
to
89e4a68
Compare
oandregal
commented
Aug 2, 2020
youknowriad
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #24250
This PR adds support for more style properties in the global context.
Testing instructions
lib/experimental-theme.json
:global-styles-inline-css
that contains a style rule with the:root
selector. For that style rule, verify that:=> does have the properties
font-size
,background-color
,background
,--wp--style--color--link
=> does not have the properties
line-height
,color