-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Align support to Separator block #25147
Conversation
Add alignment support for Separator Block
Align 'wide' and 'full' support added to Separator block
@jordesign Haii! Thanks for working on this one :) I took it for a spin locally. I think we may need My thinking is it can serve as the "default". Just in case you update to I don't think we need both Hope this was helpful! |
Thanks @ItsJonQ - I'm amended that and have an update to the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks @jordesign ! With that change, it looks good to me :)
@jordesign Hmm! Before I merge this. I had a question! Do we need the I'm not too familiar with that property. Briefly poking at the other blocks (via code search), I couldn't find many instances of Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordesign Haii! Just checked. I think we need to remove "html": false
Thanks @ItsJonQ - updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordesign Great! Thank you for the speedy adjustments 🙏
The E2E tests are failing... However, I believe we're having E2E testing issues all around. Will proceed with merging. Thanks again @jordesign ! |
@ItsJonQ To reset to the default, you click the currently-selected option. Arguably, there should be an explicit "unset"/"default" option in these kind of dropdown menus, but that's something that should be addressed for all instances of this kind of menu. |
Description
Added support for Align controls (limited to Wide and Full) to Separator block
Addresses #25080
How has this been tested?
Tested in Local (by Flywheel) on Mac OSX in Chrome/Safari.
Tested with TwentyTwenty theme which renders elements as expected (with good theme support for wide end full alignment).
Screenshots
Types of changes
Change to existing core block - adding additional functionality/support
Checklist: