LinkControl: Fix horizontal scrollbar within block toolbar #27777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .components-visually-hidden element within the control is absolutely positioned however the link control has no position: relative set. The result without it is the hidden element causes a horizontal scrollbar. This fixes that.
aaronrobertshaw
added
[Type] Bug
|
Size Change: +8 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
The design of that input doesn't look great when you hit "Edit". We might want to solve that separately. |
youknowriad
added
the
[Feature] UI Components
tellthemachines
pushed a commit
that referenced
this pull request
Feb 17, 2021
tellthemachines
added a commit
that referenced
this pull request
Feb 17, 2021
* Backport #26475 for the 5.6 branch. * Backport #28604. * Revert "Backport #28604." This reverts commit 32784b6. * Backport #26583 to the 5.6 branch. * Commit lock file updates. * Committing lock file differences after updating `browserslist`. * Pin the version of NodeJS in the Compressed Size workflow. * Memoize getEntityRecords to prevent infinite re-renders (#26447) * Fix issue where gallery block requests all attachments when empty (#28621) * Return early from building attachments for galleries * Improve code clarity * Fix link control styles to prevent scrollbar (#27777) * Update package-lock * Update package-lock again Co-authored-by: Jonathan Desrosiers <desrosj@users.noreply.github.com> Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
.components-visually-hiddenelement within the control, stating the link will open in a new tab, is absolutely positioned however the link control has no position: relative set. The end result is the hidden element causes a horizontal scrollbar. This fixes that.How has this been tested?
Manually.
Testing Instruction
Screenshots
Before
After
Types of changes
Bug fix.
Checklist: