-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg Plugin: Prettify YAML scripts #30409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉
ockham
force-pushed
the
update/prettify-yaml
branch
from
March 31, 2021 17:36
74adcd4
to
6cb3a92
Compare
Rebased. |
gziolo
added
the
Gutenberg Plugin
Issues or PRs related to Gutenberg Plugin management related efforts
label
Apr 6, 2021
ockham
added a commit
that referenced
this pull request
Apr 14, 2021
`prettier` has been able to [format YAML files since version 1.14](https://prettier.io/blog/2018/07/29/1.14.0.html) (released in July of 2018). We're starting to size up on YAML files (mostly GitHub Actions workflows), so it'd be nice to have them auto-formatted. This PR adds YAML files to the list of extensions formatted by `prettier`. Existing YAML files have already been updated to the new format by #30409. Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
desrosj
added a commit
that referenced
this pull request
Jul 2, 2021
`prettier` has been able to [format YAML files since version 1.14](https://prettier.io/blog/2018/07/29/1.14.0.html) (released in July of 2018). We're starting to size up on YAML files (mostly GitHub Actions workflows), so it'd be nice to have them auto-formatted. This PR adds YAML files to the list of extensions formatted by `prettier`. Existing YAML files have already been updated to the new format by #30409. Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> When backporting, `format-js` remains exactly the same, and only the `.yml` extension is added to the `format-js` command in `package.json`. (cherry picked from commit 06fd22e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Gutenberg Plugin
Issues or PRs related to Gutenberg Plugin management related efforts
[Type] Build Tooling
Issues or PRs related to build tooling
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spun off from #30240. That PR will update our
format-js
tool to include other files in prettification, but it still needs more work and touches 30 files already. This is an attempt to keep it a bit smaller.How has this been tested?
Verify that CI workflows still pass as before.
View the diff without whitespace changes -- the only visible changes should be a few double quote -> single quote changes in existing YAML files (the rest is all whitespace/indentation).