-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an initial value to the Site Logo block. #30907
Conversation
@@ -141,6 +141,10 @@ const SiteLogo = ( { | |||
// becomes available. | |||
const maxWidthBuffer = maxWidth * 2.5; | |||
|
|||
// Set the default width to a responsible size. | |||
// Note that this width is also set in the attached CSS file. | |||
const defaultWidth = 120; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something that we should express in theme.json as a default as well cc @nosolosw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking it at #31037
Size Change: +18 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
Description
The Site Logo block had some changes recently to set a new default width of 120px. As part of that, the initial width was unset. This PR adds back an initial width that matches the CSS properties.
Before:
After:
Checklist:
*.native.js
files for terms that need renaming or removal).