-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the percent unit to the default units in Core #33468
Conversation
Created this issue for potential follow-ups #33470 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion in #33463, 👍.
6960702
to
4c0c055
Compare
Tested and does restore Is the change also needed here https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/use-setting/index.js#L44? |
@hellofromtonya good catch, yeah I think it's better to be consistent. |
Size Change: +4 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
closes #33463
This PR restores the
%
unit in columns width but also enables it in all spacing customization tools. See discussion in #33463.I think the handling of units is still very incomplete, I'll be opening a separate issue to continue this discussion and explain some of the current flaws.