Add tooltip to navigation items in a setup state #35139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +25 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Thank you for the review. There appear to be some legitimate test failures that I'll look into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you insert a menu item in a navigation menu, without pointing it to a destination, the item exists in a setup state and will not be published. Emulating grammar tools and linters, this setup state is indicated by a blue wavy underline:
This PR adds a tooltip to the item, indicating why there's a wavy underline:
This will also benefit #35094, which allows a label to exist in the setup state.
How has this been tested?
Insert a navigation block, click "Start empty". Add a Page Link item, but don't choose a destination, instead click outside or press "Escape". Now hover the menu item and observe the tooltip.
Checklist:
*.native.jsfiles for terms that need renaming or removal).