Block Templates: Fix PHP notices on WP 5.8 #36964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the plugin runs on WP 5.8.x, it will use the
WP_Block_Template
class from the core, which doesn't have new properties. To avoid PHP notices, we've to use dynamic properties when building templates from the file.Note: The issue doesn't affect WP 5.9.
How has this been tested?
WP_DEBUG_LOG
enabled.debug.log
shouldn't contain notices.Log
Types of changes
Bugfix
Checklist:
*.native.js
files for terms that need renaming or removal).