Add block styles slot to the site editor so block style previews can be rendered #40245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Feature] Site Editor
|
Size Change: +17 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Apr 12, 2022
|
This is working well for me, thanks for adding it in. Before
After
I also checked the post editor and widget editor implementations and this is consistent. ✅ Other PRs for reference: |
andrewserong
approved these changes
Apr 12, 2022
andrewserong
added
[Type] Bug
adamziel
pushed a commit
that referenced
this pull request
Apr 12, 2022
…be rendered (#40245) Co-authored-by: Glen Davies <glen.davies@a8c.com>
adamziel
removed
the
Backport to WP 6.7 Beta/RC
|
This was backported to 13.0 RC3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds
BlockStyles.Slotto the site editorWhy?
Currently block style previews are not rendered when they are hovered or focused in the site editor. Fixes: #40064
How?
Adds
BlockStyles.Slotinto the site editor content areaTesting Instructions
Screenshots or screencast
Before:
preview-before.mp4
After:
preview-after.mp4