-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacer: Complete TypeScript migration of component #42013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Feature] UI Components
Impacts or related to the UI component system
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Components
/packages/components
labels
Jun 28, 2022
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, Storybook also looks good 🚀
Special thanks for adding details on how each padding and margin prop is supposed to override other less-specific props 🙏
Feel free to merge once the small changelog-related comment is addressed!
walbo
force-pushed
the
refactor/spacer-to-typescript
branch
from
July 1, 2022 14:02
f481753
to
35ffcb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Completes the migration of
Spacer
component to TypeScript.Why?
Part of the @wordpress/components's TypeScript migration (#35744).
How?
Testing Instructions
Spacer
continues to function as expected