Popover: fix arrow placement and design #42874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
|
Size Change: +368 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
fix/popover-arrow
branch
from
8a1a39e
to
54505b5
Compare
ciampo
changed the title
mirka
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Looks great, thanks for the quick fix!
At first I was wondering why the Add New Template dropdown is offset a little bit lower than before and no longer overlaps the header, but I guess we can consider this a consistency improvement since it's the same offset as other Dropdowns without the arrow. Like the Options dropdown in the editor:
ntsekouras
reviewed
Aug 2, 2022
I see both "sides" of the argument, but I agree with your point — this could be seen as a step towards consistency. But even if we changed our mind and wanted to move the popover closer to the "Add new" button, I would suggest that we do it in a separate PR so that we keep this one focused on the arrow fix. |
ntsekouras
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Awesome work here Marco! 💯
I took a brief look at this yesterday and saw the many things missing from arrow handling. I've tested your PR by changing every Dropdown we have to show an arrow and everything seemed great(both in post and site editors).
I've left a few small comments/questions and I'd like to know more especially for this one. I know you'll have some small cleanup to do, but this looks good to me!
|
FWIW, the Add New Template dropdown probably shouldn't have an arrow. I think it's the only dropdown in the codebase that has one, so that could be seen as an inconsistency. |
I'm not an expert when it comes to this part of the codebase, and so I'll happily let other folks make changes to that specific dropdown in a separate PR, if necessary. We can keep this PR focused on the Popover arrow fixes |
ciampo
force-pushed
the
fix/popover-arrow
branch
from
6a23692
to
04e37ba
Compare
|
All feedback should be addressed. I've also rebased and removed the temporary code for the Storybook example and the If no one has any objections, I'm planning on merging this PR later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42820
What?
Fix a regression introduced in #40740 about the
Popover's arrow placement.Why?
The
Popover's arrow has currently a few issues:How?
In order to fix the arrow placement, the following changes were implemented:
xandycoordinates received fromuseFloating(mainly switching from! Number.isNaNtoNumber.isFinite)45deg, switched to a proper triangle (coded in SVG)$arrow-triangle-base-sizeSCSS variableI've also added two extra temporary commits (which I will remove before merging)
ownerDocumentis always defined insidePopover(this fix should probably be moved to its own separate PR)Testing Instructions
/wp-admin/site-editor.php?postType=wp_templateand click the "Add New" button in the top right part of the screen. Make sure that the Popover's arrow placement and design look correct (see this comment for more details)For extra thoroughness, you could revert the
Popover: fix arrow logic, use SVG to render trianglecommit in this PR and verify that the bug is not fixed in the scenarios described above.Screenshots or screencast
Before:
Kapture.2022-08-01.at.23.14.26.mp4
After:
Kapture.2022-08-01.at.23.10.43.mp4