Global Styles: Duotone palette doesn't reflect settings in theme.json #43671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +1.53 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ajlende
reviewed
Aug 29, 2022
packages/edit-site/src/components/global-styles/gradients-palette-panel.js
Outdated
Show resolved
Hide resolved
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #43384
What?
This PR ensures that the duotone panel in the global style panel reflects the settings in
theme.json.Why?
Currently, the
settings.color.defaultDuotoneintheme.jsonis not taken into account, so the default duotone palette is always displayed.How?
Changed to match the palette of the duotone picker in blocks, taking into account the settings in
theme.json.Testing Instructions
settings.color.defaultDuotoneandsettings.color.duotoneintheme.jsonto create different variations.Should only show default duotone palette
{ "$schema": "https://schemas.wp.org/wp/6.0/theme.json", "version": 2, "settings": { "color": { } } }Should not show duotone palette
{ "$schema": "https://schemas.wp.org/wp/6.0/theme.json", "version": 2, "settings": { "color": { "defaultDuotone": false } } }Should only show custom duotone palette
{ "$schema": "https://schemas.wp.org/wp/6.0/theme.json", "version": 2, "settings": { "color": { "defaultDuotone": false, "duotone": [ { "colors": [ "#ff0000", "#ffff00" ], "slug": "red-and-yellow", "name": "Red and Yellow" }, { "colors": [ "#ff0000", "#00ff00" ], "slug": "red-and-green", "name": "Red and Green" } ] } } }Should show both dafult and custom duotone palettes
{ "$schema": "https://schemas.wp.org/wp/6.0/theme.json", "version": 2, "settings": { "color": { "duotone": [ { "colors": [ "#ff0000", "#ffff00" ], "slug": "red-and-yellow", "name": "Red and Yellow" }, { "colors": [ "#ff0000", "#00ff00" ], "slug": "red-and-green", "name": "Red and Green" } ] } } }