[RNMobile] Enable rendering a block's SVG icon directly from an XML string #55742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
2 tasks
|
Flaky tests detected in ca132d2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6783027745
|
SiobhyB
pushed a commit
to Automattic/jetpack
that referenced
this pull request
Nov 3, 2023
For native, we're updating the logic for parsing a block icon if it's a string. See: WordPress/gutenberg#55742 Given those changes, we can now pass the "metadata.icon" string directly when registering a block on native.
Co-Authored-By: Carlos Garcia <14905380+fluiddot@users.noreply.github.com>
SiobhyB
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#6342
What?
This PR enables rendering a block's SVG icon directly from an XML string.
Why?
When a block's registered, especially if it's registered via metadata, it's possible for the icon to be passed as a string beginning with
"<svg". In such cases, the icon would not be displayed, as such a string is not encountered for when registering a block on native.How?
react-native-svgincludes a function,SvgXml, that is useful for parsing XML strings. This function is now exported as part of the@wordpress/primitivespackage.In addition a
SvgXmlmock has been added, following the same pattern as other mocked components.Testing Instructions
Testing Instructions for Keyboard
N/A