Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry picked nine prs for Release/18.0 RC2 #60216

Closed
wants to merge 13 commits into from
Closed

Cherry picked nine prs for Release/18.0 RC2 #60216

wants to merge 13 commits into from

Conversation

bph
Copy link
Contributor

@bph bph commented Mar 26, 2024

What?

Cherry-picked these PRs
#59959 – 6e614c5 – Fix list of base theme fonts w...
#60071 – 7b6ac8d – Navigation: Avoid content loss...
#60130 – f217ef0 – Fix self closing navigation ov...
#60162 – dbd4cec – Fix code formatting in Nav blo...
#60167 – 447c008 – Fix root ID calculation when c...
#60187 – 1d7407b – Featured Image: Fix overlay re...
#60184 – 90907af – Featured Image: Fix block supp...
#60180 – f9effe4 – Font Library: install fonts in...
#60093 – d158d9b – Activate the fonts coming from...

Why?

In preparation for 18.0 RC2

gutenbergplugin and others added 13 commits March 21, 2024 14:21
@gutenbergplugin
Bump plugin version to 18.0.0-rc.1
f8d0068
@gutenbergplugin
Update Changelog for 18.0.0-rc.1
7991316
@gutenbergplugin
Update changelog files
0019b88
@gutenbergplugin
chore(release): publish
7f75bb1 
 - @wordpress/a11y@3.54.0
 - @wordpress/annotations@2.54.0
 - @wordpress/api-fetch@6.51.0
 - @wordpress/autop@3.54.0
 - @wordpress/babel-plugin-import-jsx-pragma@4.37.0
 - @wordpress/babel-plugin-makepot@5.38.0
 - @wordpress/babel-preset-default@7.38.0
 - @wordpress/base-styles@4.45.0
 - @wordpress/blob@3.54.0
 - @wordpress/block-directory@4.31.0
 - @wordpress/block-editor@12.22.0
 - @wordpress/block-library@8.31.0
 - @wordpress/block-serialization-default-parser@4.54.0
 - @wordpress/block-serialization-spec-parser@4.54.0
 - @wordpress/blocks@12.31.0
 - @wordpress/browserslist-config@5.37.0
 - @wordpress/commands@0.25.0
 - @wordpress/components@27.2.0
 - @wordpress/compose@6.31.0
 - @wordpress/core-commands@0.23.0
 - @wordpress/core-data@6.31.0
 - @wordpress/create-block@4.38.0
 - @wordpress/create-block-interactive-template@1.17.0
 - @wordpress/create-block-tutorial-template@3.8.0
 - @wordpress/customize-widgets@4.31.0
 - @wordpress/data@9.24.0
 - @wordpress/data-controls@3.23.0
 - @wordpress/dataviews@0.8.0
 - @wordpress/date@4.54.0
 - @wordpress/dependency-extraction-webpack-plugin@5.5.0
 - @wordpress/deprecated@3.54.0
 - @wordpress/docgen@1.63.0
 - @wordpress/dom@3.54.0
 - @wordpress/dom-ready@3.54.0
 - @wordpress/e2e-test-utils@10.25.0
 - @wordpress/e2e-test-utils-playwright@0.22.0
 - @wordpress/e2e-tests@7.25.0
 - @wordpress/edit-post@7.31.0
 - @wordpress/edit-site@5.31.0
 - @wordpress/edit-widgets@5.31.0
 - @wordpress/editor@13.31.0
 - @wordpress/element@5.31.0
 - @wordpress/env@9.6.0
 - @wordpress/escape-html@2.54.0
 - @wordpress/eslint-plugin@17.11.0
 - @wordpress/format-library@4.31.0
 - @wordpress/hooks@3.54.0
 - @wordpress/html-entities@3.54.0
 - @wordpress/i18n@4.54.0
 - @wordpress/icons@9.45.0
 - @wordpress/interactivity@5.3.0
 - @wordpress/interactivity-router@1.4.0
 - @wordpress/interface@5.31.0
 - @wordpress/is-shallow-equal@4.54.0
 - @wordpress/jest-console@7.25.0
 - @wordpress/jest-preset-default@11.25.0
 - @wordpress/jest-puppeteer-axe@6.25.0
 - @wordpress/keyboard-shortcuts@4.31.0
 - @wordpress/keycodes@3.54.0
 - @wordpress/lazy-import@1.41.0
 - @wordpress/list-reusable-blocks@4.31.0
 - @wordpress/media-utils@4.45.0
 - @wordpress/notices@4.22.0
 - @wordpress/npm-package-json-lint-config@4.39.0
 - @wordpress/nux@8.16.0
 - @wordpress/patterns@1.15.0
 - @wordpress/plugins@6.22.0
 - @wordpress/postcss-plugins-preset@4.38.0
 - @wordpress/postcss-themes@5.37.0
 - @wordpress/preferences@3.31.0
 - @wordpress/preferences-persistence@1.46.0
 - @wordpress/prettier-config@3.11.0
 - @wordpress/primitives@3.52.0
 - @wordpress/priority-queue@2.54.0
 - @wordpress/private-apis@0.36.0
 - @wordpress/project-management-automation@1.53.0
 - @wordpress/react-i18n@3.52.0
 - @wordpress/readable-js-assets-webpack-plugin@2.37.0
 - @wordpress/redux-routine@4.54.0
 - @wordpress/reusable-blocks@4.31.0
 - @wordpress/rich-text@6.31.0
 - @wordpress/router@0.23.0
 - @wordpress/scripts@27.5.0
 - @wordpress/server-side-render@4.31.0
 - @wordpress/shortcode@3.54.0
 - @wordpress/style-engine@1.37.0
 - @wordpress/stylelint-config@21.37.0
 - @wordpress/sync@0.16.0
 - @wordpress/token-list@2.54.0
 - @wordpress/undo-manager@0.14.0
 - @wordpress/url@3.55.0
 - @wordpress/viewport@5.31.0
 - @wordpress/warning@2.54.0
 - @wordpress/widgets@3.31.0
 - @wordpress/wordcount@3.54.0
@matiasbenedetto @getdave
@scruffian @mikachan @bph
Fix list of base theme fonts when a theme variation is applied. (#59959)
aab2adc 
* use globalStyles + theme.json base files to render a list of avialble fonts in the font library modal. Avoid fonts with duplicated slugs.

* add comments

* improve comment

* fix typo in comment

Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com>

---------

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
@Mamaduka @jsnajdr
@annezazu @bph
Navigation: Avoid content loss when only specific entity fields are e…
96ffcf1 
…dited (#60071)


Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
@draganescu @scruffian
@SantosGuillamot @annezazu @fabiankaegy @huzaifaalmesbah @youknowriad @colorful-tones @bph
Don't close the overlay when hovering out of pre prendered submenus (#…
07871b8 
…60130)


Unlinked contributors: ariel-maidana.

Co-authored-by: draganescu <andraganescu@git.wordpress.org>
Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Co-authored-by: kjnanda <krupajnanda@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
Co-authored-by: liviopv <liviopv@git.wordpress.org>
@getdave @bph
Fix formatting in Nav block view file (#60162)
fc77423
@jsnajdr @mcsf
@annezazu @youknowriad @bph
Fix root ID calculation when check if block can be transformed (#60167)
01f32c8 
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@aaronrobertshaw @bph
Featured Image: Fix overlay rendering in the editor (#60187)
c434380
@aaronrobertshaw @bph
Featured Image: Fix block support selectors after shadow support added (
1cd464d 
#60184)
@creativecoder @getdave
@mcsf @peterwilsoncc @mikachan @huzaifaalmesbah @t-hamano @swissspidy @bph
Font Library: install fonts in sequence to work around race condition (…
671b80a 
…#60180)

* Font Library: install fonts in sequence to work around font directory race condition

* Update comment block to coding standards

Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>

* Fix linting

---------

Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: kjnanda <krupajnanda@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
@matiasbenedetto @mikachan
@getdave @mcsf @carolinan @huzaifaalmesbah @annezazu @bph
Activate the fonts coming from the backend and not the data from the …
5ed745a 
…frontend (#60093)

* Activate the fonts coming from the backend and not the data from the frontend

* add comment

-----

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Co-authored-by: srueegger <kim88@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @gutenbergplugin.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: gutenbergplugin.

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: draganescu <andraganescu@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@bph bph added Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Mar 26, 2024
@getdave getdave added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Mar 26, 2024
getdave
getdave requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is picking changes into trunk. However, I believe the commits are already on the release/18.0 branch:

https://github.com/WordPress/gutenberg/tree/release/18.0

Not sure what happened. Maybe automation?

@getdave
Copy link
Contributor

getdave commented Mar 26, 2024

Looking at the docs that’s [the commits picked directly into the release branch] expected behaviour. You don’t need to raise a PR to cherry pick the changes.

So unless I’m mistaken we can close this one out and all you need do is run the RC release.

@bph bph closed this Mar 26, 2024
@getdave getdave removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getdave getdave getdave requested changes

@ObliviousHarmony ObliviousHarmony Awaiting requested review from ObliviousHarmony ObliviousHarmony is a code owner

@t-hamano t-hamano Awaiting requested review from t-hamano t-hamano is a code owner

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@fluiddot fluiddot Awaiting requested review from fluiddot

@dcalhoun dcalhoun Awaiting requested review from dcalhoun

@gziolo gziolo Awaiting requested review from gziolo gziolo is a code owner

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@talldan talldan Awaiting requested review from talldan talldan is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy swissspidy is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc peterwilsoncc is a code owner

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher ryanwelcher is a code owner

@kevin940726 kevin940726 Awaiting requested review from kevin940726 kevin940726 is a code owner

@luisherranz luisherranz Awaiting requested review from luisherranz luisherranz is a code owner

@DAreRodz DAreRodz Awaiting requested review from DAreRodz DAreRodz is a code owner

@draganescu draganescu Awaiting requested review from draganescu draganescu is a code owner

@adamziel adamziel Awaiting requested review from adamziel adamziel is a code owner

@dmsnell dmsnell Awaiting requested review from dmsnell dmsnell is a code owner

@atimmer atimmer Awaiting requested review from atimmer atimmer is a code owner

@mmtr mmtr Awaiting requested review from mmtr mmtr is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

Assignees
No one assigned
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bph @getdave @gutenbergplugin @matiasbenedetto @Mamaduka @draganescu @jsnajdr @aaronrobertshaw @creativecoder