Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #6105 regarding drop cap-related display error #6133

Closed
wants to merge 2 commits into from

Conversation

twsp
Copy link
Contributor

@twsp twsp commented Apr 12, 2018

Description

I removed the "overflow: hidden" property that was being applied to blocks with drop caps when they were not in focus. This code was causing text to not properly wrap, as described in issue #6105, and did not seem to have any other effects in other situations unrelated to the issue.

Fixes #6105

How Has This Been Tested?

I tested this by recreating the problem with the steps in the aforementioned issue, changing the code, and ensuring that it had the desired effect without any unintended consequences.

Screenshots (jpeg or gifs if applicable):

This is how the text looked when out of focus before the issue was fixed:
dropcap2

This is how it looks when out of focus after the fix:
dropcap1

Types of changes

This is a bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@aduth aduth added [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. and removed Needs Design Feedback Needs general design feedback. labels Apr 13, 2018
@danielbachhuber
Copy link
Member

The overflow:hidden appears to have come out of 8dfc4c5, which was introduced in #1418.

Based on that PR though, it's not super clear where the original dropcap CSS is from. @BE-Webdesign Do you recall?

@aduth
Copy link
Member

aduth commented Jun 21, 2018

It appears this was addressed separately in #6359. Thanks for the contribution all the same!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling drop cap creates incorrectly flowed text
3 participants