-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lock snackbar for modifying content lock blocks #61845
Draft
kevin940726
wants to merge
1
commit into
trunk
Choose a base branch
from
add/modify-content-lock-snackbar
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Enhancement
A suggestion for improvement.
Needs Design Feedback
Needs general design feedback.
[Feature] Block Locking
The API allowing for the ability to lock/unlock blocks
labels
May 22, 2024
Size Change: +174 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Flaky tests detected in 0fdbafd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9186598055
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Block Locking
The API allowing for the ability to lock/unlock blocks
Needs Design Feedback
Needs general design feedback.
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Close #61554.
Add a "Done editing? Lock" snackbar for easier access to re-lock a modifying content-locked block.
Note
This UI is still TBD. This PR is created to help with testing.
Why?
See #61554. This is a UI enhancement to improve the discoverability of the feature.
How?
Add a snackbar once users enter the temporary modifying mode.
Testing Instructions
Screenshots or screencast
Kapture.2024-05-22.at.14.40.31.mp4