Add eslint rule for curly brace presence in JSX #62026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniGuardiola
requested review from
ajitbohra,
tellthemachines,
ellatrix,
artemiomorales,
michalczaplinski and
geriux
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
added
the
[Type] Code Quality
|
Size Change: -692 B (-0.04%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c3922be. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9272561203
|
tyxla
reviewed
May 27, 2024
There was a problem hiding this comment.
Thanks for this 🙌
Getting the static analysis check to pass should be pretty straightforward, I've left a few suggestions. I'd prefer getting it fixed here and now, since the errors are actually introduced (or start to be reported) since this PR.
Other than that, good to go, this brings some nice consistency to the codebase 👍
|
Note: After merging the PR, let's add the merge commit hash to the |
…int/jsx-curly-brace-presence
Mamaduka
reviewed
May 28, 2024
…int/jsx-curly-brace-presence
tyxla
approved these changes
May 29, 2024
| <Provider value={ { value: '2nd provided' } }> | ||
| <Consumer>{ ( context ) => context.value }</Consumer> | ||
| </Provider> | ||
| { '|' } | ||
| <Consumer>{ ( context ) => context.value }</Consumer> | ||
| |<Consumer>{ ( context ) => context.value }</Consumer> |
There was a problem hiding this comment.
Should these | have been on separate lines?
There was a problem hiding this comment.
I was also a bit weirded out by this, and ran a full pass of formatting just in case. Seems to be just a bit of a weird edge case, but it conforms with auto-formatting so 🤷♂️
There was a problem hiding this comment.
cc @jsnajdr: Prettier is being unpretty here 😅
There was a problem hiding this comment.
I need some more info about what exactly is the problem. Prettier didn't do the change from { '|' } to |, did it? It was done manually to fix (or autofix) the curly brace rule, right?
Is the new syntax incorrect? Does it produce, for example, more or less whitespace that expected in the rendered HTML?
Or is it just unpleasant to look at?
There was a problem hiding this comment.
Looks like it was auto-fixed but I'll let @DaniGuardiola confirm.
Looks unpleasant to me, but I'm happy to just not look at it too much. 😅
There was a problem hiding this comment.
It's correct, just unpretty :)
The unnecessary curly was eslint autofix, but as I said above I did a full formatting pass afterwards just in case and there were no changes, so this is how prettier likes it.
|
It looks like base branch was little out of the date and we missed a spot, which currently causing CI check to fail - #62109. |
|
Followed up to ignore this commit in git blame in: #62144. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* Add rule. * Run autofixes. * Disable react/no-unescaped-entities * Use useInstanceId * Disable entities rule inline. Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Add rule. * Run autofixes. * Disable react/no-unescaped-entities * Use useInstanceId * Disable entities rule inline. Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #61969 (comment)
Rule docs: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-curly-brace-presence.md
This rule is autofixable and, with the current configuration, has this effect:
This PR enables the rule (see
.eslintrcand applies the fix throughout the repo. This is a completely safe fix as the semantics are the same.Note: the lint CI errors showing up in this PR are, to the best of my knowledge, pre-existing. They are probably being triggered simply because the PR is touching these files. They should be safe to ignore for the purposes of this PR, though I think it would be beneficial to take a full pass at the whole repo and squash (or mindfully silence) these errors entirely, in a separate PR.