Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for PostTrash & PostTrashCheck TimeToRead TextEditorGlobalKeyboardShortcuts PostPublishButtonLabel Component #62116

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

narenin
Copy link
Contributor

@narenin narenin commented May 29, 2024

What?

Addresses one item in #60358

Why?

Adding documentation to existing PostTrash & PostTrashCheck TimeToRead TextEditorGlobalKeyboardShortcuts PostPublishButtonLabel components can help with any of the following:

encourages knowledge sharing and quicker onboarding for future devs
supports maintenance and troubleshooting

Testing Instructions

This PR justs adds a JSDoc comment to the PostTrash & PostTrashCheck TimeToRead TextEditorGlobalKeyboardShortcuts PostPublishButtonLabel component and populates the README with the new documents generated by running npm run docs:build

Copy link

github-actions bot commented May 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: narenin <narenin@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil
Copy link
Member

@narenin Would you please also add doc for PostTrashCheck in this PR?

@narenin
Copy link
Contributor Author

narenin commented May 30, 2024

@akasunil I have added the documentation for PostTrashCheck please check.

@narenin narenin changed the title Added documentation for PostTrash Component Added documentation for PostTrash & PostTrashCheck Component May 30, 2024
@narenin narenin changed the title Added documentation for PostTrash & PostTrashCheck Component Added documentation for PostTrash & PostTrashCheck TimeToRead TextEditorGlobalKeyboardShortcuts PostPublishButtonLabel Component May 30, 2024
@colorful-tones colorful-tones added the [Type] Developer Documentation Documentation for developers label May 30, 2024
Copy link
Member

@colorful-tones colorful-tones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@colorful-tones colorful-tones merged commit 79ffe95 into WordPress:trunk Jun 14, 2024
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 14, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
…TextEditorGlobalKeyboardShortcuts` `PostPublishButtonLabel `Component (WordPress#62116)

* Added documentation for PostTrash Component

* Added Documentation for PostTrashCheck component

* Added Documentation for PostPublishButtonLabel TimeToRead and TextEditorGlobalKeyboardShortcuts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants