Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block.json schema: Add supports.splitting field #62209

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jun 2, 2024

Related to #54543

What?

This PR adds supports.splitting field to the block.json schema.

Why?

This new field is a public API and therefore needs to be defined in the schema.

How?

I created a description field based on the content of #54543, but it was difficult to explain well. If you have any suggestions for a more understandable explanation, I would be grateful.

Testing Instructions

Create a JSON file like the one below locally and check that the code editor suggests "splitting".

{
	"$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/block-json-schema-splitting/schemas/json/block.json",
	"apiVersion": 3,
	"title": "Test",
	"name": "test/test",
	"supports": {
	}
}

image

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Jun 2, 2024
@t-hamano t-hamano self-assigned this Jun 2, 2024
@t-hamano t-hamano force-pushed the block-json-schema-splitting branch from 4ec1244 to 1b31974 Compare June 2, 2024 14:54
@t-hamano t-hamano marked this pull request as ready for review June 2, 2024 15:00
Copy link

github-actions bot commented Jun 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

schemas/json/block.json Outdated Show resolved Hide resolved
Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
@ellatrix ellatrix added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 5, 2024
@t-hamano t-hamano merged commit 0f78e61 into trunk Jun 5, 2024
65 checks passed
@t-hamano t-hamano deleted the block-json-schema-splitting branch June 5, 2024 14:36
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 5, 2024
ellatrix added a commit that referenced this pull request Jun 11, 2024
* block.json schema: Add supports.splitting field

* Update schemas/json/block.json

Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>

---------

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
ellatrix added a commit that referenced this pull request Jun 11, 2024
* block.json schema: Add supports.splitting field

* Update schemas/json/block.json

Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>

---------

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
* block.json schema: Add supports.splitting field

* Update schemas/json/block.json

Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>

---------

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
@ellatrix ellatrix removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 18, 2024
@ellatrix
Copy link
Member

This was cherry-picked to the wp/6.6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants