Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add network-active to valid options in PluginStatus Type definition #62450

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

fabiankaegy
Copy link
Member

What?

Adds network-active to valid options in PluginStatus type definition

Why?

It is a valid option that the Rest API returns: https://github.com/WordPress/wordpress-develop/blob/bca94a5fe45f9414f0d11a16372895a4817b1716/src/wp-includes/rest-api/endpoints/class-wp-rest-plugins-controller.php#L61

How?

Adding the string to the type

@fabiankaegy fabiankaegy added the [Type] Code Quality Issues or PRs that relate to code quality label Jun 10, 2024
@fabiankaegy fabiankaegy self-assigned this Jun 10, 2024
@fabiankaegy fabiankaegy requested a review from nerrad as a code owner June 10, 2024 15:51
Copy link

github-actions bot commented Jun 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @fabiankaegy!

@fabiankaegy fabiankaegy merged commit 3b10cb6 into trunk Jun 10, 2024
69 checks passed
@fabiankaegy fabiankaegy deleted the fix/plugin-status-types branch June 10, 2024 16:53
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 10, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
…inition (WordPress#62450)

Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants