Zoom Out: Try click to disengage #62699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +9 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Good instincts. I think the biggest headache right now is exactly that it's a bit far from both the cursor, and where focus is, how to close/exit the inserter in zoom mode. Here's trunk:
Note here that at one point I'm pressing Esc with the intent to close the inserter. That does appear to toggle off zoom out mode, but it doesn't close my patterns, or the inserter. Here's this branch:
This branch does the same, except as the description notes, click twice on a block and it disengages zoom out mode. The problem in both cases is that the inserter remains open. Perhaps that's me personally, but that feels like the biggest headache to solve; can the inserter fully close when I press Esc? Clicking twice can do the same, that seems reasonable. My instinct also goes towards clicking anywhere in the gray gutter should close the inserter—the action I'm doing there is one of intentionally setting focus there by clicking. The main risk here is the vertical toolbar we want to show in this mode, we wouldn't want you to accidentally close the inserter, and thus zoom out mode, if you miss one of those buttons. |
|
Did a quick test on this and found some oddities, namely trying to double click to get out and clicking in the template editing area, getting a notice. Along with this, when double clicking to get out, it's a bit odd where the Inserter with the patterns over top of it covers the editing experience: double.click.mov |
|
@scruffian We solved in #64573 right? Can we close? |
|
I think we can close, but also exploring something similar in #65286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is just an experiment to see how it feels to use click to disengage zoom out.
The way it works is that it listens to clicks on a block. If you click the same block more than once in succession then zoom out mode is disengaged.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast