DataViews: remove selection correcting, set initial state #62796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -30 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ellatrix
commented
Jun 24, 2024
jorgefilipecosta
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Nice improvements, thank you for working on this! In my tests, I did not find any regression and this is a good simplification to the selection management.
We probably need a better long-term solution for selection management, when a destructive action happens, but I guess the current solution is ok for now.
ellatrix
commented
Jun 24, 2024
ellatrix
commented
Jun 24, 2024
ellatrix
force-pushed
the
try/data-views-selection-fix
branch
from
9e6d51c
to
2c82fda
Compare
ellatrix
force-pushed
the
try/data-views-selection-fix
branch
from
eed8eb3
to
20db2cf
Compare
ellatrix
added
the
Backport to WP 6.7 Beta/RC
ellatrix
added
[Type] Bug
Fixed in 00737ac |
|
Flaky tests detected in 6dfee63. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9657299622
|
ellatrix
added a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
ellatrix
added
Backported to WP Core
ellatrix
added a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Just trying this as an alternative to both #62787 and #62792.
If DataViews doesn't try to correct the selection when items don't exist or are removed (I think that should be the concern of the implementor), then we can also simply set an initial state.
Why?
Reduces the amount of state setting in effects, which reduces the probability of infinite loops.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast