Post editor: Fix triple scrollbars in device previews #62940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
the
[Type] Regression
|
Size Change: +7 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 780284a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9701280175
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
added
General Interface
|
I've also made another small PR that only shows the second device preview scrollbar when really needed - #62952 |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 28, 2024
* Fix triple scrollbars in post editor * Restore flex of VisualEditor when metaboxes are present Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: ec9720d |
|
I came across this PR while investigating the issue reported in #63110. This PR may have caused two issues for the post editor that is not iframed and does not have meta boxes.
"The post editor that is not iframed and does not have meta boxes" refers to when a block version 3 or below is registered without custom fields enabled. In this case, the For more information on this issue, see #63110. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #62911
A fix for a regression in the Post editor where device previews create three scrolling areas.
Why?
In WP 6.5 device previews in the Post editor don’t have three scrolling areas.
How?
Revises a selector to more selectively apply some styles that cause the issue. The styles appear to only be helpful when metaboxes are present.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After
More about the issue
As best I can tell this came about from introducing the "Zoom out" experiment. While that is still an experiment it did introduce markup and style changes that are present even when not opting into the experiment. Testing WP nightly in playground I can reproduce the issue:
