Font Library: Add 'No fonts installed' message on library tab when fonts aren't available #63740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +37 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f66e8b6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10058214358
|
t-hamano
reviewed
Jul 20, 2024
|
Curious, do we need a Library tab if there's no contents in the Library tab? |
It would also be possible to hide the Library tab when there is no font. If we implemented this approach, the Library tab would appear the moment you add a font from the "Upload" or "Install Fonts" tab for the first time. Another concern is what happens when you delete a font in the Library tab. I'm worried that it will be confusing if the Library tab suddenly disappears when you delete the last font. |
It require to update all its parent styles to have full height. |
t-hamano
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
LGTM!
but the text might be better centered, like the DataViews
It require to update all its parent styles to have full height.
That's true. This will have a bit of a big impact because we'll need to adjust the styles across this content to center the text.
This wouldn't be hard to achieve if the entire modal content was composed of flex, but since that's not the case currently, we'll address this in a future follow-up.
Got it, ill create separate issue for it and will get feedback from design team. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #63731
Why?
There isnt any message indicating that no fonts are installed on library tab of font library modal.
How?
This PR add message on library tab of font library modal when no fonts are installed.
Testing Instructions
No fonts installed.Screenshots or screencast
Index-.-Template-.-gutenberg-.-Editor-.-WordPress.2.webm