DataViews Extensibility: Allow unregistering trash post action #64087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +178 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Works as expected. I didn't notice any regression after migration ✅
Side note: When trashing a post from the post editor, the editor renders a "missing entity" state. This wasn't the case with the old "Move to Trash" button; we should probably try and fix it. See 2s-3s in screencast.
CleanShot.2024-07-30.at.13.53.06.mp4
swissspidy
reviewed
Jul 30, 2024
|
|
||
| const trashPost: Action< PostWithPermissions > = { | ||
| id: 'move-to-trash', | ||
| label: __( 'Move to Trash' ), |
There was a problem hiding this comment.
I know this wasn't introduced in this PR, but:
I thought we use sentence case nowadays? i.e. Move to trash with lowercase t.
| ? sprintf( | ||
| // translators: %s: The item's title. | ||
| __( | ||
| 'Are you sure you want to move to trash "%s"?' |
There was a problem hiding this comment.
I know this wasn't introduced in this PR, but:
This is odd grammar. Wouldn't one say "Are you sure you want to move XYZ to the trash?"
Comment on lines
+61
to
+62
| 'Are you sure you want to move to trash %d item?', | ||
| 'Are you sure you want to move to trash %d items?', |
There was a problem hiding this comment.
I know this wasn't introduced in this PR, but:
This is odd grammar. Wouldn't one say "Are you sure you want to move XYZ item(s) to the trash?"
| typedError.reason.message; | ||
| } else { | ||
| errorMessage = __( | ||
| 'An error occurred while moving to trash the item.' |
There was a problem hiding this comment.
Ditto here and everywhere below... "An error occurred while moving the item to the trash"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #61084
Similar to #62647
What?
In #62052 an API to register and unregister dataviews actions has been implemented. But in order to allow third-party developers to be able to unregister these actions, we need to be using the same actions in Core to register the core actions. The current PR explore the possibility to use the API to register one action: "trash post".
Testing Instructions
1- Open the pages dataviews and try moving a page to the trash.
2- You should be able to see the "move to trash" action in the actions dropdown menu
3- you can try to use the action.