Fix: Make ⌘A's select all the blocks again

[jorgefilipecosta]

Description

Fixes: #7711
Regressed in: #7644

Moves the logic to handle meta+a to be before the check for event.nativeEvent.defaultPrevented. The event was default prevented by TinyMCE.

How has this been tested?

Some smoke testing.
Added multiple paragraphs with text and checked that pressing ⌘A's multiple selected all the blocks.

[mtias]

There's a typo here "Aobrt"

[aduth]

End-to-end test failure is legitimate. This is basically undoing what was meant to be fixed by #7644 / #6712

[aduth]

Re-regresses #7644 . _navigationHandled isn't a thing. It's basically the same as if the condition isn't there at all.

[afercia]

Also related: #7445

[jorgefilipecosta]

This PR was updated it now reorders the check for ⌘A event to be before the check for event.nativeEvent.defaultPrevented. It seems TinyMCE applies a prevent default in the event.

[aduth]

Future tasks:

• Split WritingFlow#onKeyDown into more sensible isolated function handlers (we shouldn't have both block traversal and Cmd+A behaviors in the same function, it contributed to the introduction of the regression)
• Try to interoperate better with TinyMCE's preventDefault, e.g. perhaps exploring the SelectAll command which is the source of the preventDefault, either stripping the default TinyMCE behavior, refactoring our 2x Cmd+A to act in response to the SelectAll command (similar to Undo/Redo propagation), or abandoning effort to use native preventDefault in favor of an implementation-specific property like which had existed prior to Rich Text: Detect handled horizontal navigation by preventDefault #7644

On glance, this looks good. Will take a closer look soon. Travis appears to be having a bad day.

[ellatrix]

Worth leaving a comment on the order?

[jorgefilipecosta]

Well remembered, the comment was added.

[ellatrix]

Looks fine to me. Added an e2e test to ensure we don't break it in the future. Arrow nav still works as expected.

The PR was updated to use another approach.

[jorgefilipecosta]

Thank you for the review and for suggesting this approach @aduth. Thank you @iseulde for the review and for the end to end test 👍

[aduth]

Thanks for the added end-to-end test!

[mcsf]

Just noting that, at least as of today:

• Firefox requires three ⌘A presses.
• Safari doesn't seem to care about this feature at all.

[mcsf]

I see the above is sort of tracked in #8180, so disregard. :)