-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix send email query #4281
Fix send email query #4281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes make sense and work as expected.
@@ -33,6 +33,18 @@ class Meta: | |||
description = Faker("catch_phrase") | |||
email = Faker("email") | |||
|
|||
@factory.post_generation | |||
def application(obj, create, extracted, **kwargs): | |||
# Only create the application if creating, and either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Only create the application if creating, and either | |
# Only create the application if creating ??, and either |
If creating ThrottledApplication
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If creating the registration. create
refers to the factory's state: https://factoryboy.readthedocs.io/en/stable/reference.html#postgeneration
create
is a boolean indicating which strategy was used
* Fix send email query * Fix doc strings
Fixes
Related to #3742 by @sarayourfriend
Description
See #2037 (comment) for a description of the problem needing solving in this PR.
I've marked this as critical because we need to get this email sent as soon as possible, which means we need to deploy this to production ASAP so we can run the command there.
Testing Instructions
Confirm your understanding of the problem as described in the linked comment, then check whether the modified query would solve the issue. For clarity, I have run the query in production as follows:
This returns 1628 rather than the 2 that the original query returned.
Checklist
Update index.md
).main
) or a parent feature branch.just catalog/generate-docs
for catalogPRs) or the media properties generator (
just catalog/generate-docs media-props
for the catalog or
just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin