-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version qualifiers in pyproject.toml
files
#4632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for accommodating these changes!
It seems like the content hash was updated for utilities/dead_links
, but didn't for the other 2 utilities projects?
Signed-off-by: Olga Bulat <obulat@gmail.com>
I'm not sure why that happened. Do you know if the lock files are not updated when different pdm versions are used, @dhruvkb ? |
Signed-off-by: Olga Bulat <obulat@gmail.com>
a5a299f
to
e0fee75
Compare
Sorry, I don't know what happens if PDM encounters a lockfile generated by an older version of itself. |
Fixes
Related to #4166 by @dhruvkb
Description
@dhruvkb has flagged the fact that the PRs migrating to PDM were setting versions incorrectly, not in the way we use in the API.
This PR updates the version qualifiers:
>=x.y
->>=x.y.z, <x+1
.This prevents PDM from updating the version to the next major version.
Testing Instructions
CI should pass.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin