Make test-php-watch cross-platform compatible via fswatch
#2110
Conversation
westonruter
requested review from
mukeshpanchal27,
felixarntz and
thelovekesh
as code owners
westonruter
added
no milestone
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
added
the
[Type] Enhancement
bin/test-php-watch.sh
Outdated
| exit 1 | ||
|
|
||
| # Check for the fswatch command | ||
| if ! which fswatch >/dev/null 2>&1; then |
There was a problem hiding this comment.
Just a tiny optional suggestion: I feel command -v might be a bit more portable across POSIX systems and tends to behave more consistently between GNU and BSD variants than which. Not a blocker at all, just tossing it out there in case it's helpful.
There was a problem hiding this comment.
Good idea. Could you amend the PR with that suggestion?
Co-authored-by: Weston Ruter <weston@ruter.net> Signed-off-by: Shyamsundar Gadde <shyamsundar.gadde@rtcamp.com>
I first developed the
test-php-watchcommand (#1401) when I was using Linux for my development environment. Since switching (back) to Mac, I discovered thatinotify-toolsis only for Linux. Therefore, this PR switches out theinotifywaitcommand for thefswatchcommand which is cross-platform.