Allow a prop format to be specified #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjorbin
reviewed
Feb 6, 2024
desrosj
force-pushed
the
feature/allow-choice-of-format
branch
from
a2db431
to
131e335
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronjorbin
reviewed
Feb 6, 2024
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
…/props-bot-action into feature/allow-choice-of-format
aaronjorbin
approved these changes
Feb 6, 2024
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 6, 2024
The new default is a git flavored version, while Core wants the SVN flavor. This update is required after WordPress/props-bot-action#61 Props desrosj, jorbin, noisysocks, gziolo. See #60417. git-svn-id: https://develop.svn.wordpress.org/trunk@57544 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 6, 2024
The new default is a git flavored version, while Core wants the SVN flavor. This update is required after WordPress/props-bot-action#61 Props desrosj, jorbin, noisysocks, gziolo. See #60417. Built from https://develop.svn.wordpress.org/trunk@57544 git-svn-id: http://core.svn.wordpress.org/trunk@57045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Feb 6, 2024
The new default is a git flavored version, while Core wants the SVN flavor. This update is required after WordPress/props-bot-action#61 Props desrosj, jorbin, noisysocks, gziolo. See #60417. Built from https://develop.svn.wordpress.org/trunk@57544 git-svn-id: https://core.svn.wordpress.org/trunk@57045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
aaronjorbin
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 64511b5.
aaronjorbin
added a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This updates the action to allow a repository to configure the specific formats they want included in the bot's comments.
Why?
Often times, only one format is relavent to a given repo. This also helps make the comment shorter. Including both formats makes it quite long.
How?
Using the
formatsinput,all,git, orsvncan now be specified. The default isgit.Fixes #38, #47.