Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite: Incorrect @access annotations #38

Closed
swissspidy opened this issue May 16, 2023 · 2 comments
Closed

SQLite: Incorrect @access annotations #38

swissspidy opened this issue May 16, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@swissspidy
Copy link
Member

Bug Description

The SQLite modules has some classes with actual private methods, which also have a @access private annotation.

That is redundant and against the coding standards.

See https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#1-functions-class-methods

A private function xyz() does not need @access private annotations.

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

Additional Context

  • PHP Version:
  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Plugin Version: [e.g. 22]
  • Device: [e.g. iPhone6]
@westonruter westonruter added the good first issue Good for newcomers label May 16, 2023
@mukeshpanchal27
Copy link
Member

In the performance team's meeting on 2023-04-25, it was decided to decouple the SQLite module from the Performance Lab plugin. Therefore, I don't think we need to address this issue. Instead, we can open an issue in https://github.com/WordPress/sqlite-database-integration.

cc. @felixarntz @joemcgill

@swissspidy swissspidy transferred this issue from WordPress/performance May 22, 2023
@swissspidy
Copy link
Member Author

Makes sense, just transferred the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants