Improve Query Monitor setup to better support multisite installs #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @johnbillion |
For more context, the SQLite & Query Monitor integration is now a working prototype with a few tricks and hacks on our side. It's on my TODO list to propose some changes upstream to https://github.com/johnbillion/query-monitor/ to make the integration more robust. |
JanJakes
force-pushed
the
query-monitor-multisite
branch
from
7b1469a to
7b32fd0
Compare
|
I'll go ahead and merge this to tag and test it with v2.2.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Query Monitor setup to better support multisite installs.
The Query Monitor integration logic tries to eagerly check whether the Query Monitor plugin is active. This is non-trivial for multisites (at that stage, we don't know yet which site is active, etc.).
I created a fix that doesn’t do the eager load on multisites. All is set up correctly a bit later, when the QM plugin loads. Not loading it eagerly means we won't log a couple of queries that WP core does before it loads the QM plugin.
For single sites, the eager load is still in place.