This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
approved these changes
Nov 28, 2018
|
@richtabor thanks for fixing it 💯 |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Dec 14, 2018
This update changes the following: - Add proper frontend styles for center aligned archive and category blocks. More info here: WordPress/twentynineteen#684 - Fix image_filter theme option conditional function. More info here: WordPress/twentynineteen#680 - Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. Props richtabor. More info here: WordPress/twentynineteen#686 Props richtabor, kjellr. See #45424. git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44193 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 15, 2018
This update changes the following: - Add proper frontend styles for center aligned archive and category blocks. More info here: WordPress/twentynineteen#684 - Fix image_filter theme option conditional function. More info here: WordPress/twentynineteen#680 - Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. Props richtabor. More info here: WordPress/twentynineteen#686 Props richtabor, kjellr. See #45424. Built from https://develop.svn.wordpress.org/branches/5.0@44193 git-svn-id: http://core.svn.wordpress.org/branches/5.0@44023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Dec 15, 2018
This update changes the following: - Add proper frontend styles for center aligned archive and category blocks. More info here: WordPress/twentynineteen#684 - Fix image_filter theme option conditional function. More info here: WordPress/twentynineteen#680 - Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. Props richtabor. More info here: WordPress/twentynineteen#686 Props richtabor, kjellr. See #45424. Built from https://develop.svn.wordpress.org/branches/5.0@44193 git-svn-id: https://core.svn.wordpress.org/branches/5.0@44023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Dec 18, 2018
This update changes the following: - Properly sets the primary color hue theme option. See WordPress/twentynineteen#683. - Add proper frontend styles for center aligned archive and category blocks. See WordPress/twentynineteen#684. - Fix `image_filter` theme option conditional function. See WordPress/twentynineteen#680. - Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. See WordPress/twentynineteen#686. Props richtabor, kjellr, allancole. Merges [44192] and [44193] to trunk. See #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44302 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Dec 18, 2018
This update changes the following: - Properly sets the primary color hue theme option. See WordPress/twentynineteen#683. - Add proper frontend styles for center aligned archive and category blocks. See WordPress/twentynineteen#684. - Fix `image_filter` theme option conditional function. See WordPress/twentynineteen#680. - Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. See WordPress/twentynineteen#686. Props richtabor, kjellr, allancole. Merges [44192] and [44193] to trunk. See #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44302 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 19, 2018
This update changes the following: - Properly sets the primary color hue theme option. See WordPress/twentynineteen#683. - Add proper frontend styles for center aligned archive and category blocks. See WordPress/twentynineteen#684. - Fix `image_filter` theme option conditional function. See WordPress/twentynineteen#680. - Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. See WordPress/twentynineteen#686. Props richtabor, kjellr, allancole. Merges [44192] and [44193] to trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44302 git-svn-id: http://core.svn.wordpress.org/trunk@44132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Dec 19, 2018
This update changes the following: - Properly sets the primary color hue theme option. See WordPress/twentynineteen#683. - Add proper frontend styles for center aligned archive and category blocks. See WordPress/twentynineteen#684. - Fix `image_filter` theme option conditional function. See WordPress/twentynineteen#680. - Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. See WordPress/twentynineteen#686. Props richtabor, kjellr, allancole. Merges [44192] and [44193] to trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44302 git-svn-id: https://core.svn.wordpress.org/trunk@44132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
svn2github
pushed a commit
to svn2github/wp-svn-2-git
that referenced
this pull request
Dec 21, 2018
This update changes the following: - Properly sets the primary color hue theme option. See WordPress/twentynineteen#683. - Add proper frontend styles for center aligned archive and category blocks. See WordPress/twentynineteen#684. - Fix `image_filter` theme option conditional function. See WordPress/twentynineteen#680. - Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. See WordPress/twentynineteen#686. Props richtabor, kjellr, allancole. Merges [44192] and [44193] to trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44302 git-svn-id: http://core.svn.wordpress.org/trunk@44132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #660
Here's a screen recording of me adding a separator block followed by a heading block (H2). The rule-line from the H2 is removed now. No more duplicate rule-lines! 👌
Before:
After: