Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Pattern: About - Image on the right, heading and paragraph #137

Merged
merged 8 commits into from
Sep 2, 2024

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Aug 27, 2024

Fixes: #65

Screenshot:

about-the-event

Instructions:

  • Create a page.
  • Add the pattern.
  • Confirm that it's looking like the designs (spacing/colors/text etc).

@shail-mehta shail-mehta force-pushed the overview-text-with-image branch from fc66bf4 to 243b6bf Compare August 31, 2024 03:47
@shail-mehta shail-mehta changed the title Pattern: Overview Text With Image Pattern: Heading and paragraph with image on the right Aug 31, 2024
@shail-mehta shail-mehta marked this pull request as ready for review August 31, 2024 06:37
Copy link

github-actions bot commented Aug 31, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta changed the title Pattern: Heading and paragraph with image on the right Pattern: About - Image on the right, heading and paragraph Aug 31, 2024
@carolinan
Copy link
Contributor

Hi!
Please update the PR with the latest changes from trunk.

Then, remove the background color and text colors: both the attributes in the block comments and the class name.
And then apply the colors by using the new dark and white section style, style 4.

In other words, the color declarations should be removed and replaced with the CSS class name that WordPress uses to apply the section style.

"className":"is-style-section-4"


Tip:
Insert the pattern
Select the outer group block and remove the background color. Apply the section style in the group block options.
Select the columns and remove the text color.

Now you have all the changes you need and you can copy the new class name into the existing pattern file.
Remember that you must not include the meta data.

@shail-mehta shail-mehta force-pushed the overview-text-with-image branch from a13cefa to c425ada Compare September 1, 2024 14:16
@shail-mehta
Copy link
Member Author

Thanks for the feedback.

I have Rebased current branch & used section style & also removed contrast & base color for text color & background color.

@carolinan
Copy link
Contributor

Thank you!

@carolinan carolinan merged commit 2804d28 into WordPress:trunk Sep 2, 2024
4 checks passed
@shail-mehta shail-mehta deleted the overview-text-with-image branch September 2, 2024 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Patterns - About - Image on the right, heading and paragraph
2 participants