Adding PHPUnit tests for get_post_states function #10060
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| $invalid_length = 0; | ||
| $count = 0; | ||
| $max_count = $max_code_points ?? PHP_INT_MAX; | ||
| $byte_length = strlen( $bytes ); |
There was a problem hiding this comment.
This update is correct but feels a little random in this PR.
There was a problem hiding this comment.
Yes sorry, each time I execute the composer format command before pushing it adds this correction.
Should I isolate it in its own PR that could be merge to trunk ?
There was a problem hiding this comment.
You could leave it or you can create a new PR and link it here #63168
| * @param string $post_state The post state to test. | ||
| */ | ||
|
|
||
| public function test_post_states_function( $post_state, $expected_post_state_string ) { |
There was a problem hiding this comment.
I'm comparing the original tests and the new tests
Now you are adding plenty of options.
Also, originally most were comparing an assertArrayHasKey and now they are comparting assertContains
The only two that had assertContains (trashed-customization-draft and customization-draft are not being used anymore).
Why is it so?
…ization draft cases
Adding PHPUnit tests for get_post_states function
Trac ticket: https://core.trac.wordpress.org/ticket/63167