64049: REST API: Allow comments to be edited to become empty #10083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally proposed by @adamsilverstein in #9988, this PR adds tests to his fix while also resolving a potential logical error which could prevent updates to unrelated comment object properties.
Undefined array key "comment_content"
(failing on the last line ofcheck_is_comment_content_allowed
) because the controller expects to be able to process partial objects: For example, you can pass an object in a PUT which changes the author but alters no other fields.check_is_comment_content_allowed()
can be called is during the create_item method, which ensurescomment_content
is initialized to''
if not present — this should not result in any change to existing behavior on comment creation or updates.Trac ticket: https://core.trac.wordpress.org/ticket/64049
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.