Skip to content

Conversation

kadamwhite
Copy link
Contributor

@kadamwhite kadamwhite commented Sep 29, 2025

Originally proposed by @adamsilverstein in #9988, this PR adds tests to his fix while also resolving a potential logical error which could prevent updates to unrelated comment object properties.

  • Enable empty block comments #9988 as written causes an error in some existing unit tests (including my newly-added one for this ticket), Undefined array key "comment_content" (failing on the last line of check_is_comment_content_allowed) because the controller expects to be able to process partial objects: For example, you can pass an object in a PUT which changes the author but alters no other fields.
  • We therefore only want to check the content for emptiness (and verify using the filter whether that is allowable) when the property has been passed back.
  • Currently, the only path through which check_is_comment_content_allowed() can be called is during the create_item method, which ensures comment_content is initialized to '' if not present — this should not result in any change to existing behavior on comment creation or updates.

Trac ticket: https://core.trac.wordpress.org/ticket/64049


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adamsilverstein, kadamwhite.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

$response = rest_get_server()->dispatch( $request );
$this->assertSame( 200, $response->get_status() );

// Sending a request with empty comment is not fine.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline doc needs to changed now it return 200 response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants