Block Editor: Try using DependencyExtractionWebpackPlugin

[gziolo]

Work in progress.

I'll move to Trac as soon as Travis turns green :)

[sirreal]

You'll want to delete these lines so the DependencyExtractionWebpackPlugin finds the externals.

wordpress-develop/tools/webpack/packages.js

Lines 110 to 124 in f8688bb

	const externals = {
	react: 'React',
	'react-dom': 'ReactDOM',
	tinymce: 'tinymce',
	moment: 'moment',
	jquery: 'jQuery',
	lodash: 'lodash',
	'lodash-es': 'lodash',
	};
	packages.forEach( ( name ) => {
	externals[ `@wordpress/${ name }` ] = {
	this: [ 'wp', camelCaseDash( name ) ],
	};
	} );

wordpress-develop/tools/webpack/packages.js

Line 187 in f8688bb

externals,

[gziolo]

@sirreal, thanks for pointers. It solved the issue 🎉

I had to include @wordpress/block-directory as a dependency. We will have to fix it on Gutenberg side first as it's hidden behind the flag and it shouldn't be necessary to be registered and enqueued in WordPress 5.3. /cc @youknowriad

@omarreiss, we add a number of PHP files for each JS script. Is it fine to keep them next to distribution version of JS files as presented on the screenshot?

The same structure is present in both build and src folders.

[gziolo]

The discussion should continue on WordPress Trac: https://core.trac.wordpress.org/ticket/48154.

[gziolo]

I updated the patch with the latest changes from the master branch.

In addition, I switched the output format for asset files to JSON.

It also looks like JSON is now required to run WordPress so we can take advantage of it:
https://make.wordpress.org/core/2019/10/15/php-native-json-extension-now-required/

[ntwb]

Based on the core trac image the php assets are now stored in the /src/wp-includes/assets/dist folder

[gziolo]

It's more complex than that.

This is where webpack generates those PHP assets, we move them to /src/wp-includes/assets/dist or /build/wp-includes/assets/dist depending where webpack operates. It's even more hard to follow when you take into account that npm run build:dev operates in src folder, but npm run build uses build folder ...

[gziolo]

This name should probably be updated to webpack-generated-assets :)

[gziolo]

@ntwb I included some tweaks to make it easier to follow. I hope it helps:

ba91cc1

[gziolo]

Resolved with https://core.trac.wordpress.org/changeset/47035.