Fix PHP8.1 throw 'Deprecated' #2248
Conversation
In PHP8.1,Implicit incompatible float to int conversion is deprecated. Because of it, wordpress will throw a PHP Deprecated in page footer.
|
Hi @devhaozi! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
| } | ||
| public function get( $num ) { | ||
| if ( isset( $this->cache[ (int) $num ] ) ) { | ||
| return $this->cache[ $num ]; |
There was a problem hiding this comment.
Should this one also be cast to (int)?
If so, can we add $num = (int) $num at the start of the get() method instead of repeating the (int) cast?
There was a problem hiding this comment.
I've also left a comment in the Trac ticket: adding the (int) cast is hiding the actual problem, not fixing it.
The origin of the notice should be traced back and the problem should be solved at the source, not here. I.e. it should be solved at the function call which is passing a float instead of an int.
ghost
closed this by deleting the head repository
In PHP8.1,Implicit incompatible float to int conversion is deprecated.
Because of it, wordpress will throw a PHP Deprecated in page footer.
Trac ticket: https://core.trac.wordpress.org/ticket/54996