Skip to content

Plugins: Avoid stomping of the variable in a plugin. #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Plugins: Avoid stomping of the variable in a plugin. #2468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/wp-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,9 @@

// Load must-use plugins.
foreach ( wp_get_mu_plugins() as $mu_plugin ) {
$_wp_plugin_file = $mu_plugin;
include_once $mu_plugin;
$mu_plugin = $_wp_plugin_file; // Avoid stomping of the $mu_plugin variable in a plugin.

/**
* Fires once a single must-use plugin has loaded.
Expand All @@ -357,13 +359,16 @@
*/
do_action( 'mu_plugin_loaded', $mu_plugin );
}
unset( $mu_plugin );
unset( $mu_plugin, $_wp_plugin_file );

// Load network activated plugins.
if ( is_multisite() ) {
foreach ( wp_get_active_network_plugins() as $network_plugin ) {
wp_register_plugin_realpath( $network_plugin );

$_wp_plugin_file = $network_plugin;
include_once $network_plugin;
$network_plugin = $_wp_plugin_file; // Avoid stomping of the $network_plugin variable in a plugin.

/**
* Fires once a single network-activated plugin has loaded.
Expand All @@ -374,7 +379,7 @@
*/
do_action( 'network_plugin_loaded', $network_plugin );
}
unset( $network_plugin );
unset( $network_plugin, $_wp_plugin_file );
}

/**
Expand Down Expand Up @@ -415,7 +420,10 @@
// Load active plugins.
foreach ( wp_get_active_and_valid_plugins() as $plugin ) {
wp_register_plugin_realpath( $plugin );

$_wp_plugin_file = $plugin;
include_once $plugin;
$plugin = $_wp_plugin_file; // Avoid stomping of the $plugin variable in a plugin.

/**
* Fires once a single activated plugin has loaded.
Expand All @@ -426,7 +434,7 @@
*/
do_action( 'plugin_loaded', $plugin );
}
unset( $plugin );
unset( $plugin, $_wp_plugin_file );

// Load pluggable functions.
require ABSPATH . WPINC . '/pluggable.php';
Expand Down