Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
561 commits
Select commit Hold shift + click to select a range
bd364c1
Added @covers to test docblock for test_standalone_after_inline_scrip…
10upsimon May 16, 2023
5c5f309
Fixed bug where defer as opposed to async was applied in test test_st…
10upsimon May 16, 2023
69a0fee
Added @covers to test docblock for test_non_standalone_after_inline_s…
10upsimon May 16, 2023
3091a99
Added @covers to test docblock for test_non_standalone_after_inline_s…
10upsimon May 16, 2023
f7a4cc4
Added @covers to test docblock for test_non_standalone_after_inline_s…
10upsimon May 16, 2023
b2c7099
Added @covers to test docblock for test_non_standalone_after_inline_s…
10upsimon May 16, 2023
f13ccc7
Added @covers to test docblock for test_non_standalone_before_inline_…
10upsimon May 16, 2023
3b735bf
Added @covers to test docblock for test_non_standalone_before_inline_…
10upsimon May 16, 2023
8fbd560
Added @covers to test docblock for test_non_standalone_before_inline_…
10upsimon May 16, 2023
b9dd1f0
Added @covers to test docblock for test_non_standalone_before_inline_…
10upsimon May 16, 2023
2dced00
Added @covers to test docblock for test_standalone_before_inline_scri…
10upsimon May 16, 2023
cddf096
Added @covers to test docblock for test_standalone_before_inline_scri…
10upsimon May 16, 2023
c3fe20a
Added @covers to test docblock for test_loading_strategy_with_valid_a…
10upsimon May 16, 2023
991d100
Added @covers to test docblock for test_loading_strategy_with_invalid…
10upsimon May 16, 2023
dd40fc4
Added @covers to test docblock for test_loading_strategy_with_valid_d…
10upsimon May 16, 2023
9dbc03f
Added @covers to test docblock for test_defer_with_async_dependent
10upsimon May 16, 2023
1ab577d
Added @covers to test docblock for test_loading_strategy_with_invalid…
10upsimon May 16, 2023
d64e740
Added @covers to test docblock for test_loading_strategy_with_valid_b…
10upsimon May 16, 2023
6980b84
Added @covers to test docblock for test_old_and_new_in_footer_scripts
10upsimon May 16, 2023
bac4a21
Added @covers to test test_get_normalized_script_args
10upsimon May 16, 2023
baa3110
Added @covers to test test_get_normalized_script_args
10upsimon May 16, 2023
a7a42bb
Added @covers to test test_script_strategy_doing_it_wrong
10upsimon May 16, 2023
ef3802a
Added @covers to test test_concatenate_with_defer_strategy
10upsimon May 16, 2023
9753ece
Added @covers to test test_concatenate_with_async_strategy
10upsimon May 16, 2023
aeed971
Added @covers to test test_concatenate_with_blocking_script_before_an…
10upsimon May 16, 2023
2f9eb85
Added test failure message to test test_non_standalone_and_standalone…
10upsimon May 16, 2023
bb3ed8d
Removed i18n wrapper from test failure message
10upsimon May 16, 2023
0803ab4
Added test failure message to test test_standalone_after_inline_scrip…
10upsimon May 16, 2023
8f89b26
Added test failure message to test test_standalone_after_inline_scrip…
10upsimon May 16, 2023
7251ac8
Added test failure message to test test_non_standalone_after_inline_s…
10upsimon May 16, 2023
e5cf314
Added test failure message to test test_non_standalone_after_inline_s…
10upsimon May 16, 2023
e6419b8
Added test failure message to test test_non_standalone_after_inline_s…
10upsimon May 16, 2023
f32a5f9
Added test failure message to test test_non_standalone_after_inline_s…
10upsimon May 16, 2023
647a320
Added test failure message to test test_non_standalone_before_inline_…
10upsimon May 16, 2023
3d98bb4
Added test failure message to test test_non_standalone_before_inline_…
10upsimon May 16, 2023
a83d69a
Added test failure message to test test_non_standalone_before_inline_…
10upsimon May 16, 2023
2fe8345
Added test failure message to test test_non_standalone_before_inline_…
10upsimon May 16, 2023
74069a1
Added test failure message to test test_standalone_before_inline_scri…
10upsimon May 16, 2023
a4efb53
Added test failure message to test test_standalone_before_inline_scri…
10upsimon May 16, 2023
0e75146
Added test failure message to test test_loading_strategy_with_valid_a…
10upsimon May 16, 2023
a9787fa
Added test failure message to test test_loading_strategy_with_invalid…
10upsimon May 16, 2023
93398b5
Docblock formatting changes
10upsimon May 16, 2023
a1083bf
Added test failure message to test test_defer_with_async_dependent
10upsimon May 16, 2023
8de98ac
Added test failure message to test test_loading_strategy_with_invalid…
10upsimon May 16, 2023
ec88f2a
Added test failure message to test test_loading_strategy_with_valid_b…
10upsimon May 16, 2023
3d58ebd
Added test failure message to test test_old_and_new_in_footer_scripts
10upsimon May 16, 2023
45f8841
Added test failure message to test test_get_normalized_script_args
10upsimon May 16, 2023
bddc5e7
Added test failure message to test test_script_strategy_doing_it_wrong
10upsimon May 16, 2023
c799b44
Added test failure message to test test_concatenate_with_defer_strategy
10upsimon May 16, 2023
41d1337
Formatting fixes
10upsimon May 16, 2023
58e3817
Added test failure message to test test_concatenate_with_defer_strate…
10upsimon May 16, 2023
ae7d4f2
Added test failure message to test test_concatenate_with_blocking_scr…
10upsimon May 16, 2023
42375ec
Add/remove necessary @covers items from doc blocks
10upsimon May 16, 2023
81abb8b
Refactored wpLoadAfterScripts to handle CSP nonce
10upsimon May 17, 2023
53741a3
Updated test cases to reflect new logic of wpLoadAfterScripts function
10upsimon May 17, 2023
0ff33a3
Revert "Update applicable core calls to wp_register_script() to refle…
10upsimon May 18, 2023
578399c
Removed comment that defined what valid loading strategies are
10upsimon May 18, 2023
212bfe6
Add explicit checks for defer and async strategies before printing af…
10upsimon May 18, 2023
e91b02c
Added more explicit checks for defer and async strategies prior to pr…
10upsimon May 18, 2023
6286300
Improve variable naming, removing _handle suffix
westonruter May 18, 2023
caa6111
Replace onload attribute with addEventListener inline script
westonruter May 18, 2023
009c081
Move type attribute to keep id as first attribute
westonruter May 18, 2023
4650457
Use single capturing load event to reliable catch defer and async scr…
westonruter May 18, 2023
8c8ff15
Update tests
westonruter May 18, 2023
321c1c7
Add missing bool variant in phpdoc for wp_register_script/wp_enqueue_…
westonruter May 22, 2023
d6c1103
Eliminate script_args script data in favor of top-level group and str…
westonruter May 22, 2023
80eb584
Support script args data being empty
westonruter May 22, 2023
d79eaee
Explicitly cast in_footer as bool
westonruter May 22, 2023
c41c5f6
Merge pull request #62 from 10up/feature/enhance-wp-scripts-api-with-…
10upsimon May 23, 2023
253595c
Improve assertion for group script data
westonruter May 23, 2023
414e90e
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
10upsimon May 25, 2023
ec2b5f9
Update doc block for method add_inline_script for better formatting
10upsimon May 25, 2023
fcc8276
Format conditionals within has_delayed_inline_script method to be mor…
10upsimon May 25, 2023
b13f763
Update formatting for doc block of WP_Scripts::get_dependents method
10upsimon May 25, 2023
f7a7c47
Update formatting for doc block of WP_Scripts::get_dependents method,…
10upsimon May 25, 2023
20b9942
Update formatting of doc block for WP_Scripts::is_valid_strategy meth…
10upsimon May 25, 2023
59c3ae0
Update formatting of doc block for WP_Scripts::is_valid_strategy meth…
10upsimon May 25, 2023
aef627f
Add new class property to store allowed loading strategies. Update i…
10upsimon May 25, 2023
cc845f8
Update doc block for WP_Scripts::get_intended_strategy method
10upsimon May 25, 2023
c1339ab
Update doc block for WP_Scripts::is_non_blocking_strategy method to b…
10upsimon May 25, 2023
542b20f
Update docblock for WP_Scripts::has_non_standalone_inline_script to b…
10upsimon May 25, 2023
cc6d86e
Update doc block for WP_Scripts::has_only_deferrable_dependents metho…
10upsimon May 25, 2023
d6ade62
Update WP_Scripts::get_eligible_loading_strategy method doc block to …
10upsimon May 25, 2023
1604557
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
westonruter May 25, 2023
713b4c8
Update doc block for WP_Scripts::get_eligible_loading_strategy to hav…
10upsimon May 25, 2023
21fa245
Update comment block within WP_Scripts::get_eligible_loading_strategy…
10upsimon May 25, 2023
d50d11b
Update comment block within WP_Scripts::get_eligible_loading_strategy…
10upsimon May 25, 2023
d17203e
Change WP_Scripts:: property to private from public, set return type …
10upsimon May 25, 2023
4ea0b08
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
westonruter May 25, 2023
ea5377b
Eliminate get_intended_strategy method in favor of putting _doing_it_…
westonruter May 25, 2023
fff6191
fixup! Eliminate get_intended_strategy method in favor of putting _do…
westonruter May 25, 2023
1cf642d
Add tests for add_data _doing_it_wrong
westonruter May 26, 2023
7475e29
Utilize dataProvider
westonruter May 26, 2023
8e65375
Add more covers tags
westonruter May 26, 2023
03faa0e
Update doc block for test method Tests_Dependencies_Scripts::test_scr…
10upsimon May 26, 2023
8cd1533
Merge pull request #64 from 10up/feature/enhance-wp-scripts-api-with-…
westonruter May 26, 2023
facaaac
Remove needless 'blocking' alias for empty strategy (which is also bl…
westonruter May 25, 2023
f9274a4
Merge pull request #66 from 10up/update/remove-blocking-value
westonruter May 26, 2023
795f1a9
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
10upsimon May 30, 2023
86a479b
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
10upsimon May 30, 2023
b6f871d
Merge branch feature/enhance-wp-scripts-api-with-a-loading-strategy i…
10upsimon May 30, 2023
ab61213
Remove reference to WP_Scripts::get_normalized_script_args in doc bl…
10upsimon May 30, 2023
77d5af0
Merge pull request #61 from 10up/pr-iteration-test-covers/enhance-wp-…
10upsimon May 30, 2023
b7e316e
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
10upsimon May 30, 2023
8de0334
Add 'since' doc block property to wp_add_inline_script to indicate in…
10upsimon May 30, 2023
cc60a2d
Update doc block for wp_add_inline_script function to be more descrip…
10upsimon May 30, 2023
157f362
Clean up doc block for wp_print_delayed_inline_script_loader function.
10upsimon May 30, 2023
bd5bce3
Simplify wp_print_inline_script_tag within wp_print_delayed_inline_sc…
10upsimon May 30, 2023
92cfb49
Fix comment block within unregister_all_script_handles function
10upsimon May 30, 2023
1256d45
Update tests following change/simplification to wp_print_delayed_inli…
10upsimon May 30, 2023
36e3fd0
WIP: Remove standalone scripts and add delayed before scripts
westonruter May 30, 2023
b3ff883
Merge branch 'trunk' into feature/enhance-wp-scripts-api-with-a-loadi…
felixarntz May 31, 2023
a635042
Reduce code duplication related to print_inline_script
westonruter May 31, 2023
5d63952
Add comment suggesting text/plain
westonruter May 31, 2023
48557cf
Print inline before scripts without delay if no deps
westonruter May 31, 2023
2596f53
Update onScriptLoad to begin to account for data-wp-deps
westonruter May 31, 2023
5b6bf1f
Move JS to separate file
westonruter May 31, 2023
d1182c5
Fix ES5-compat
westonruter May 31, 2023
8bfcd02
Remove extraneous sprintf
westonruter May 31, 2023
a39fb0b
Restore ID for before/after scripts
westonruter May 31, 2023
a6f22e9
Implement running of after scripts once dependencies have loaded
westonruter May 31, 2023
9a0f9b5
Remove unused currentNode and reformat
westonruter May 31, 2023
aeec90d
Improve function order
westonruter May 31, 2023
c8dc08a
Improve variable naming
westonruter May 31, 2023
a57bad0
Remove unnecessary variable
westonruter May 31, 2023
aabfc5d
Use delayed consistently
westonruter May 31, 2023
181d237
Revert "Remove extraneous sprintf"
westonruter May 31, 2023
340e21c
Use expected boolean for async_only arg
westonruter May 31, 2023
5c62523
Merge branch 'trunk' into feature/enhance-wp-scripts-api-with-a-loadi…
felixarntz Jun 1, 2023
06daaba
Fix bug with printing inline before scripts when there are blocking d…
westonruter Jun 1, 2023
5f88322
Output script loading stategy as data-wp-strategy attribute when defe…
10upsimon Jun 2, 2023
b100bea
Update unit tests to ensure that correct data-wp-strategy attributes …
10upsimon Jun 2, 2023
0047425
Remove obsolete comment
westonruter Jun 2, 2023
2b3a66e
Ensure script bundle dependencies are treated as blocking
westonruter Jun 2, 2023
f0db4a5
Enhance approach to getting intended and eventual strategy values for…
10upsimon Jun 2, 2023
a15aae8
Add missing default after value for position arg
westonruter Jun 5, 2023
b188285
fixup! Add missing default after value for position arg
westonruter Jun 5, 2023
b9356b9
Remove comment since false src is now initially accounted for
westonruter Jun 5, 2023
0c1f421
Restrict disabling delayed inline scripts to bundle dependencies only
westonruter Jun 5, 2023
242d426
Reuse deps variable
westonruter Jun 5, 2023
c164071
Use text/plain instead of text/template for delayed inline scripts
westonruter Jun 5, 2023
1e3d57b
Revert 0c1f421 and add explanatory comment
westonruter Jun 5, 2023
a3fd921
Merge branch 'trunk' into feature/enhance-wp-scripts-api-with-a-loadi…
felixarntz Jun 5, 2023
dc01512
Update tests and introduce assertEqualMarkup
westonruter Jun 5, 2023
d094815
Remove remaining references to standalone in tests
westonruter Jun 5, 2023
dbe1296
Remove debug comment and add explanation for why get_updated_html is …
westonruter Jun 5, 2023
644769e
Add test_delayed_dependent_with_dependencies_of_varying_strategies
westonruter Jun 6, 2023
743b665
Update logic for when an inline script should be delayed
westonruter Jun 6, 2023
3e01b07
Add test cases
westonruter Jun 6, 2023
9880f25
Simplify variable names
westonruter Jun 6, 2023
4543c31
Deprecate print_inline_script method and add covers tags
westonruter Jun 6, 2023
2979816
Add test cases for get_inline_script_data and get_inline_script_tag m…
westonruter Jun 6, 2023
6748d60
Update phpdoc for handle param
westonruter Jun 6, 2023
4e52c97
Update phpdoc params for should_delay_inline_script
westonruter Jun 6, 2023
0873006
Update phpdoc for get_inline_script_tag method
westonruter Jun 6, 2023
b68c6d2
Remove TODO comment which has been moved to an issue
westonruter Jun 6, 2023
6ae814d
Correct param phpdoc for print_inline_script method
westonruter Jun 6, 2023
6d0f16f
Clarify dependency bundle message
westonruter Jun 6, 2023
99fed8b
Fix grammar in phpdoc
westonruter Jun 6, 2023
c34b393
Prevent printing delayed-inline-script-loader if not needed
westonruter Jun 6, 2023
8bf59a1
Add missing tests for deprecated WP_Scripts::print_inline_script
westonruter Jun 6, 2023
30a8483
Merge pull request #67 from 10up/add/delayed-inline-before-scripts
westonruter Jun 6, 2023
76602e5
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
felixarntz Jun 8, 2023
76e3ac8
Ignore dependents without src to determine eligible loading strategy.
felixarntz Jun 8, 2023
1b23427
Script Loader: Ensure the delayed inline script loader is available
joemcgill Jun 8, 2023
3061a8f
Merge pull request #72 from 10up/update/fix-unit-tests-in-ci
joemcgill Jun 8, 2023
574b231
Use DOMDocument instead of WP_HTML_Tag_Processor for assertEqualMarkup
joemcgill Jun 8, 2023
6d2ff36
Move DOM parsing into helper method
westonruter Jun 8, 2023
5ae3a5b
Merge pull request #73 from 10up/fix/assert-equal-markup
westonruter Jun 8, 2023
49c0dd6
Fix heredoc-related syntax error in PHP<7.3
westonruter Jun 8, 2023
6e76fa0
Remove duplicated comment
westonruter Jun 8, 2023
9f46d3f
Remove error silencing since not needed (and PHPCS complains)
westonruter Jun 8, 2023
51a7897
Fix JSHint issues
westonruter Jun 8, 2023
538bf9d
Script Loading: Only consider enqueued dependents for eligible strategy
joemcgill Jun 9, 2023
c200422
Merge pull request #74 from 10up/update/71-use-enqueued-dependents-only
westonruter Jun 9, 2023
2289cf2
Improve phpdoc
westonruter Jun 9, 2023
b708151
Capitalize first word in comment
westonruter Jun 9, 2023
88d5223
Use expectedIncorrectUsage phpdoc tag instead of setExpectedIncorrect…
westonruter Jun 9, 2023
b50f765
Use $wp_version directly instead of get_bloginfo( 'version' )
westonruter Jun 9, 2023
e0940f3
Add message to assertSame calls
westonruter Jun 9, 2023
9668ddb
Eliminate unnecessary dataProvider
westonruter Jun 9, 2023
b5b6100
Split up test into separate tests
westonruter Jun 9, 2023
dfed918
Split up test_old_and_new_in_footer_scripts
westonruter Jun 9, 2023
3a4230b
Test that wp_print_delayed_inline_script_loader() outputs the expecte…
westonruter Jun 9, 2023
9b455b8
Use actions in test and introduce torso
westonruter Jun 9, 2023
008425d
Add failing test case delayed_inline_script_enqueued_in_torso_for_footer
westonruter Jun 9, 2023
44655b9
Add failing test case delayed_inline_printed_in_torso
westonruter Jun 9, 2023
83da501
Improve PHP comments and phpdoc
westonruter Jun 12, 2023
6df9e3f
Use associative array instead of positional array for checked handles
westonruter Jun 12, 2023
44ec35d
Add tests for has_only_delayed_dependents
westonruter Jun 12, 2023
f4309b4
Ensure delayed loader script is printed once, either in head, torso, …
westonruter Jun 12, 2023
5027a0e
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
westonruter Jun 12, 2023
e30a59f
Reset WP_Styles when testing scripts group
westonruter Jun 13, 2023
54bd2fc
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy-…
10upsimon Jun 13, 2023
41a725f
Move logic to print delayed script loader into do_items
westonruter Jun 13, 2023
4173eb9
Improve ordering of methods
westonruter Jun 13, 2023
74dd886
Remove now-unsed wp_print_delayed_inline_script_loader() global function
westonruter Jun 13, 2023
015118c
Fix print_inline_script method to return script data not script tag
westonruter Jun 13, 2023
9e80a5c
Make print_delayed_inline_script_loader method public
westonruter Jun 13, 2023
f6bf2e1
Remove now-unused unregister_all_script_handles() test helper function
westonruter Jun 13, 2023
26ae9ca
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
westonruter Jun 13, 2023
e6c0445
Merge remote-tracking branch 'origin/feature/enhance-wp-scripts-api-w…
10upsimon Jun 13, 2023
0ad5540
Improve readability of tests and flesh out comment
westonruter Jun 13, 2023
0506f7d
Alter do_item to output intended script strategy as attribute on scr…
10upsimon Jun 13, 2023
428452a
Update test suite to pass for changes made to eventual script prints …
10upsimon Jun 13, 2023
b9543ac
Add delayed_script_registered_but_not_enqueued test case
westonruter Jun 13, 2023
575c837
Format if condition to be more eligible.
10upsimon Jun 13, 2023
aabace3
Simplified check against `$intended_strategy`
10upsimon Jun 13, 2023
97ab630
Update tests/phpunit/tests/dependencies/scripts.php to fix extra whit…
10upsimon Jun 13, 2023
433082d
Merge pull request #68 from 10up/feature/enhance-wp-scripts-api-with-…
westonruter Jun 13, 2023
7b82356
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
10upsimon Jun 13, 2023
af74533
Fix PHPCS flags.
10upsimon Jun 13, 2023
643055b
Remove optional comment from process_to_do_items method
westonruter Jun 13, 2023
4512af0
Break up long line
westonruter Jun 13, 2023
64def61
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
westonruter Jun 13, 2023
259a0e6
Add data-wp-strategy attribute from #68
westonruter Jun 13, 2023
c748a91
Merge branch 'update/delayed-script-loader-printing' of https://githu…
westonruter Jun 13, 2023
6d289c5
Merge pull request #75 from 10up/update/delayed-script-loader-printing
westonruter Jun 13, 2023
ecb3ef4
Fix phpcs issues from #75
westonruter Jun 13, 2023
4bf2129
Remove erroneous dependency
westonruter Jun 14, 2023
6cf2c78
Fix dependency in one_delayed_dependent
westonruter Jun 14, 2023
f3e70bf
Fix async_not_only_with_defer_dependency test case
westonruter Jun 14, 2023
a674039
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
westonruter Jun 14, 2023
82d1579
Merge pull request #77 from 10up/update/has-only-delayed-dependents-c…
westonruter Jun 14, 2023
24a77fb
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
10upsimon Jun 15, 2023
27a3812
Inline Docs: Update test descriptions
10upsimon Jun 15, 2023
e499918
Refer to aliases instead of bundles
westonruter Jun 16, 2023
f3d3c44
Improve handling of dependency aliases
westonruter Jun 16, 2023
b06affe
Add key exists check to mirror parent add_data method
westonruter Jun 16, 2023
bbec078
Add test case to show deferral of jquery
westonruter Jun 16, 2023
7382052
Merge branch 'feature/enhance-wp-scripts-api-with-a-loading-strategy'…
10upsimon Jun 16, 2023
aa01734
Merge branch 'trunk' of github.com:10up/wordpress-develop into trunk
10upsimon Jun 16, 2023
712f714
Merge branch 'trunk' into feature/enhance-wp-scripts-api-with-a-loadi…
10upsimon Jun 16, 2023
47b2cbc
Use isset() instead of array_key_exists() for perf
westonruter Jun 16, 2023
805370e
Use more isset() instead of array_key_exists() for perf
westonruter Jun 16, 2023
c28fa9a
Simplify conditionals by using ternary
westonruter Jun 16, 2023
e72fcc0
Factor out logic into has_inline_script helper method
westonruter Jun 16, 2023
57582d7
Account for aliases having nested aliases
westonruter Jun 16, 2023
4af0d23
Avoid needlessly recursing among dependencies when only looking at de…
westonruter Jun 16, 2023
9f66c06
Add test ensuring that an async alias gets converted to defer when th…
westonruter Jun 16, 2023
9cb97ab
Remove erroneous expected delayed-inline-script-loader
westonruter Jun 16, 2023
5a14464
Merge pull request #80 from 10up/update/delayed-dependency-bundle-han…
westonruter Jun 16, 2023
ab89f96
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
westonruter Jun 16, 2023
37ffa3d
Fix broken test due to jQuery version upgrade
westonruter Jun 16, 2023
b7d362d
Remove support for delayed inline scripts (#81)
joemcgill Jun 22, 2023
4d5027a
Fix CS errors
joemcgill Jun 22, 2023
365f232
Fix CS issues in tests
joemcgill Jun 22, 2023
ae1e417
Apply suggested docs changes
joemcgill Jun 23, 2023
dc1b203
Cast as a string when initialized
joemcgill Jun 23, 2023
78bb58f
Don't double escape the src value
joemcgill Jun 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@
"globals": {
"_": false,
"Backbone": false,
"console": false,
"jQuery": false,
"JSON": false,
"wp": false,
"export": false,
"module": false,
"require": false
"require": false,
"Set": false
}
}
2 changes: 2 additions & 0 deletions phpcs.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@

<!-- From DOMDocument. -->
<element value="childNodes"/>
<element value="firstChild"/>
<element value="formatOutput"/>
<element value="lastChild"/>
<element value="nodeName"/>
<element value="nodeType"/>
<element value="parentNode"/>
Expand Down
Loading