-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Block Hooks: Apply block hooks to plugin-registered templates #9418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
bbed6bd
to
cbc1205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @Adi-ty! I tested with the testing steps from WordPress/gutenberg#71139 and I can confirm that:
- In the frontend, the template from the plugin correctly displays the hooks:
Before | After |
---|---|
![]() |
![]() |
- When making a request to
/wp-json/wp/v2/templates/twentytwentyfive//plugin-template
, the template in the response now has the hooks applied to the content.
Before | After |
---|---|
![]() |
![]() |
- That is not a problem when accessing the template in the site editor (ie:
/wp-admin/site-editor.php?canvas=edit&p=%2Fwp_template%2Ftwentytwentyfive%2F%2Fplugin-template
). Hooks are still rendered only once.
I'm approving from my side, but I don't have permisions in WP core. @ockham wondering if you (or somebody you know) can help us move this forward?
Thanks for testing and confirming the changes. Hopefully we can get this moved forward soon. |
Thank you both! I'll go ahead and commit this 👍 |
This PR fixes an inconsistency where block hooks were not being applied to templates registered by plugins using
register_block_template()
.Trac ticket: https://core.trac.wordpress.org/ticket/63808
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.