Skip to content

Conversation

SirLouen
Copy link
Member

@SirLouen SirLouen commented Sep 1, 2025

For this reviewed patch I've considered these elements:

  1. I've taken as the fix: https://core.trac.wordpress.org/attachment/ticket/62468/fix-wp-update-post.patch
    It was unnecesary to preserving date of publish and private on draft/pending posts. Only future is relevant in this scenario

  2. For the unit tests I've taken this one by @Sukhendu2002, removing all the extra AI fluff. The data provider feels a bit overkill but I think it will don't do any harm.

  3. Finally, given that here is a good opportunity to open a specific file to cover wp_update_posts I've brought all the tests covering this function and merged them all into this file for Unit Tests organizational purposes.

Trac ticket: https://core.trac.wordpress.org/ticket/62468


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Sep 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sirlouen, peterwilsoncc, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Sep 1, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few notes inline.

@SirLouen
Copy link
Member Author

SirLouen commented Sep 3, 2025

@peterwilsoncc as a rule of thumb, in a bug, I don't like to add tests that cannot be proven with and without the patch (like in TDD). But I've taken advantage of the dataProvider to add a number of cases, including those you mentioned (some are implicit, for example, a publish to future in the past, ending in publish as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants