Skip to content

Fix: Incorrect post status if user is behind the site time-zone #9711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix: Incorrect post status if user is behind the site time-zone #9711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b83db
Fix: Incorrect post status if user is before site time-zone
karthikeya-io Sep 2, 2025
cb9429a
Lint: Fix JSHint warnings
karthikeya-io Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/js/_enqueues/admin/inline-edit-post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,15 @@ window.wp = window.wp || {};
post_date_string += ' ' + $(':input[name="hh"]').val() + ':' + $(':input[name="mn"]').val() + ':' + $(':input[name="ss"]').val();
var post_date = new Date( post_date_string );
status = $('._status', rowData).text();
if ( 'future' !== status && Date.now() > post_date ) {
// Convert browser Date into site timezone before comparing.
var browserDate = new Date();
var browserOffset = browserDate.getTimezoneOffset();
var siteOffset = browserOffset;
if ( window.inlineEditPostConfig && window.inlineEditPostConfig.siteTzOffset ) {
siteOffset = parseInt( window.inlineEditPostConfig.siteTzOffset, 10 );
}
var siteDate = new Date( browserDate.getTime() + (browserOffset - siteOffset) * 60000 );
if ( 'future' !== status && siteDate > post_date ) {
$('select[name="_status"] option[value="future"]', editRow).remove();
} else {
$('select[name="_status"] option[value="publish"]', editRow).remove();
Expand Down
8 changes: 8 additions & 0 deletions src/wp-admin/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,14 @@
$wp_list_table->prepare_items();

wp_enqueue_script( 'inline-edit-post' );
wp_localize_script(
'inline-edit-post',
'inlineEditPostConfig',
array(
// get the site offset and convert to minutes.
'siteTzOffset' => (int) ( - get_option( 'gmt_offset' ) * 60 ),
)
);
wp_enqueue_script( 'heartbeat' );

if ( 'wp_block' === $post_type ) {
Expand Down
Loading