Skip to content

Onchange escape #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
+42 −10
Open

Onchange escape #9810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b057a82
Try esc escaping
joedolson Sep 9, 2025
d77be4a
Prevent change event if change happens on esc
joedolson Sep 9, 2025
1accde8
Extend to archives widget; fix indenting.
joedolson Sep 9, 2025
9062d4e
Update src/wp-includes/widgets/class-wp-widget-archives.php
joedolson Sep 15, 2025
1ff250f
Update src/wp-includes/widgets/class-wp-widget-archives.php
joedolson Sep 15, 2025
edaebf6
This wasn't supposed to stay in here.
joedolson Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/wp-includes/widgets/class-wp-widget-archives.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,28 @@ public function widget( $args, $instance ) {
<?php ob_start(); ?>
<script>
(function() {
var dropdown = document.getElementById( "<?php echo esc_js( $dropdown_id ); ?>" );
function onSelectChange() {
if ( dropdown.options[ dropdown.selectedIndex ].value !== '' ) {
document.location.href = this.options[ this.selectedIndex ].value;
}
var dropdown = document.getElementById( '<?php echo esc_js( $dropdown_id ); ?>' ), lastkey;
function onSelectChange(e) {
setTimeout(function() {
lastKey = dropdown.getAttribute( 'data-lastkey' );
if ( 'change' === e.type && 'escape' === lastKey ) {
return;
}
if ( dropdown.options[ dropdown.selectedIndex ].value !== '' ) {
document.location.href = this.options[ this.selectedIndex ].value;
}
}, 250 );
}
dropdown.addEventListener( 'keyup', function(e) {
if ( 'Escape' === e.key ) {
dropdown.setAttribute( 'data-lastkey', 'escape' );
} else {
dropdown.removeAttribute( 'data-lastkey' );
}
});
dropdown.addEventListener( 'click', function() {
dropdown.removeAttribute( 'data-lastkey' );
});
dropdown.onchange = onSelectChange;
})();
</script>
Expand Down
26 changes: 21 additions & 5 deletions src/wp-includes/widgets/class-wp-widget-categories.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,28 @@ public function widget( $args, $instance ) {

<script>
(function() {
var dropdown = document.getElementById( "<?php echo esc_js( $dropdown_id ); ?>" );
function onCatChange() {
if ( dropdown.options[ dropdown.selectedIndex ].value > 0 ) {
dropdown.parentNode.submit();
}
var dropdown = document.getElementById( '<?php echo esc_js( $dropdown_id ); ?>' ), lastkey;
function onCatChange(e) {
setTimeout(function() {
lastKey = dropdown.getAttribute( 'data-lastkey' );
if ( 'change' === e.type && 'escape' === lastKey ) {
return;
}
if ( dropdown.options[ dropdown.selectedIndex ].value > 0 ) {
dropdown.parentNode.submit();
}
}, 250 );
}
dropdown.addEventListener( 'keyup', function(e) {
if ( 'Escape' === e.key ) {
dropdown.setAttribute( 'data-lastkey', 'escape' );
} else {
dropdown.removeAttribute( 'data-lastkey' );
}
});
dropdown.addEventListener( 'click', function() {
dropdown.removeAttribute( 'data-lastkey' );
});
dropdown.onchange = onCatChange;
})();
</script>
Expand Down
Loading