Hash in the `landingPage` URL gets duplicated and doesn't work

[dkotter]

In setting up a public preview for one of our plugins (Simple Local Avatars to be specific) I was wanting to land the user on a specific settings page and ideally have them be taken to the proper section of that page by utilizing a hash in the URL.

I set the landingPage property to the following:

"landingPage": "\/wp-admin\/options-discussion.php#show_avatars",

When the Playground loads, it sends me to that settings page but the URL contains the hash part twice: /wp-admin/options-discussion.php#show_avatars#show_avatars and I believe because of that, it doesn't jump the user down to the proper place on the page. If I remove the extra hash and hit enter, it does load and jump correctly.

Not sure if there's something I'm doing wrong here that's causing that double hash or if there's something else I need to do to escape this value. I tried replacing the hash (#) with the encoded property instead (%23) but that also didn't work.

If helpful, you can see / test the Playground URL here: 10up/simple-local-avatars#252 (comment)

[adamziel]

Oh, interesting – thank you for reporting! A hash in the landingPage value is absolutely a valid use-case that never occurred to me.

[adamziel]

The landingPage redirection is handled in here:

wordpress-playground/packages/playground/blueprints/src/lib/compile.ts

Lines 191 to 193 in fa0bf6a

	await (playground as any).goTo(
	blueprint.landingPage || '/'
	);

The "double hashing" probably happens somewhere down the rabbit hole of goTo.

[karthick-murugan]

Hi @dkotter,

Just following up to see if this issue is still occurring. I tested the URL and it appears to be working correctly now, as the landing page navigates to the appropriate section as expected.

Could you please confirm if everything looks good on your end as well?

Thanks!

[dkotter]

@karthick-murugan Had not re-tested this since I opened this PR but in testing now, does seem to work as expected now, thanks!